Generalize load module #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, no need for a new helper function. Here is an example: |
rbu9fe
force-pushed
the
generalize-load-module
branch
2 times, most recently
from
b44e3fe to
196ddd7
Compare
|
@rjarry Thanks for the hint, now it works as expected. However, the check-commits task fails due to some formatting issue of the JSON tree caused by test $(curl -f -X GET -L --no-progress-meter \
-H "Accept: application/vnd.github+json" \
-H "X-GitHub-Api-Version: 2022-11-28" \
"$api_url/issues/${1##*/}" | jq -r .state) = openCan you please take a look? |
rjarry
force-pushed
the
generalize-load-module
branch
3 times, most recently
from
b0766e1 to
196ddd7
Compare
For some reason, storing the output of curl into a bash variable breaks UTF-8 encoding. Use a shell pipeline to prevent any encoding from happening. Signed-off-by: Robin Jarry <[email protected]>
Add parameters to define Yang model revision and features that shall be enabled. Closes: CESNET#101 Signed-off-by: Matthias Breuninger <[email protected]>
Expects that all features are enabled due to the "*" input. Closes: CESNET#101 Signed-off-by: Matthias Breuninger <[email protected]>
rjarry
force-pushed
the
generalize-load-module
branch
from
196ddd7 to
672e050
Compare
|
Thanks @rjarry ! |
|
@rjarry Can you please add a Git tag including that change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #101, however, it doesn't work as expected and I don't know why. Perhaps you can give me a hint?
The issue is how to pass a list of features into the C API. I implemented the helper function
strlist2cfor that purpose based on the example in the ffi documentation: An example of calling a main-like thingHowever, the pointers/memory received by the C API seem not to be valid.
Do you have an idea what's going wrong here?