cmpto_j2k: vcomp/vdec lossless additional features/cleanup #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If able to get the ext info, show J2K codestream lossiness type. Otherwise, throw a warning, but continue on since it shouldn't affect the ability to decode.
If a lossless cstream is requested, quantization isn't needed. Notify the user that quality is ignored when :lossless selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there @MartinPulec!
Submitting this PR to make a few additional changes to cmpto_j2k vcomp/vdec:
vdec/cmpto_j2k
cmpto_j2k_dec_cstream_get_ext_img_infoto get lossiness information from the cstream while probing the internal format. If successful, print the image lossiness type. Otherwise, warn the user that the query was unsuccessful and continue since this does not affect the decoder's ability to decode an image.vcomp/cmpto_j2k
:losslessis requested, only callcmpto_j2k_enc_cfg_set_losslesssince quantization is ignored in the case of a lossless compression. Otherwise, callcmpto_j2k_enc_cfg_set_quantization.:lossless.:quality=#is ignored when:losslessis used.