legacy: add new route to resolve legacy file links#2179
Merged
zzacharo merged 1 commit intoCERNDocumentServer:mainfrom Apr 28, 2026
Merged
legacy: add new route to resolve legacy file links#2179zzacharo merged 1 commit intoCERNDocumentServer:mainfrom
zzacharo merged 1 commit intoCERNDocumentServer:mainfrom
Conversation
zzacharo
reviewed
Apr 27, 2026
| except (NoResultFound, PIDDoesNotExistError, ResolverError, KeyError, TypeError): | ||
| abort(404) | ||
|
|
||
| # It's project, try the first video record |
Contributor
There was a problem hiding this comment.
I think here we have better utilities to be sure that it is a project. If we rely on this then it might be that video records without files are wrongly identified as "projects"
| if not record.get("_files", []): | ||
| videos = record.get("videos", []) | ||
| if videos: | ||
| video_pid = videos[0]["$ref"].split("/")[-1] |
Contributor
There was a problem hiding this comment.
can we iterate through all of them and "break" on the first time we find the file name?
zubeydecivelek
force-pushed
the
legacy-file-redirection
branch
from
7540ce1 to
7d67059
Compare
zzacharo
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these links are not working http://cds.cern.ch/record/281782/files/B00001470.tif