fix(frames): correct extracted frame timestamp calculation#2175
Merged
zzacharo merged 1 commit intoCERNDocumentServer:mainfrom Apr 22, 2026
Merged
fix(frames): correct extracted frame timestamp calculation#2175zzacharo merged 1 commit intoCERNDocumentServer:mainfrom
zzacharo merged 1 commit intoCERNDocumentServer:mainfrom
Conversation
zzacharo
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frame timestamps were calculated with start_time + (i + 1) * time_step. Because enumerate(frames) starts at i = 0, the very first extracted frame was being stored with a timestamp one full step later than its actual position in the video.
Example:
start_time = 5s
time_step = 10s
extracted frames correspond to positions 5s, 15s, 25s, ...
(i + 1) logic stored them as:
This means every frame timestamp was shifted forward by one interval.