Implemented the Bare Metal invoice and processor classes #154
+133
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to improve readability, since we would always want processing for credits and discounts to be done after all other processing steps that just adds metadata
QuanMPhm
commented
Feb 26, 2025
| ].copy() | ||
| ] | ||
| filtered_data = ( | ||
| filtered_data[ # TODO Does it make sense to test this filter in test cases? |
Contributor
Author
There was a problem hiding this comment.
Does it make sense to test this filter in test cases for this processor class?
QuanMPhm
commented
Feb 26, 2025
| filtered_data = self._filter_nonbillables(data) | ||
| filtered_data = self._filter_missing_pis(filtered_data) | ||
| filtered_data = self._filter_excluded_su_types(filtered_data) | ||
| filtered_data = self._filter_bm_projects(filtered_data) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #152. This PR consists of 3 commits to 1. implement the processor, 2. the invoice, and 3. a minor readability comment.
I am submitting this as a draft for now because I do not know how we want to identify BM projects. Refer to this comment for more context.
I also have a few small questions down below.