Fix SSA compliance issues #2310 - #2316
Open
alaotach wants to merge 6 commits into
Open
Conversation
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 6077cf5...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit c328108...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
Reason for this PR:
Sanity check:
Repro instructions:
DresdenTest.tssample provided in Issue Substation Alpha (SSA/ASS) output is not fully compliant with format specification #2310: DresdenTest.tsccextractor DresdenTest.ts -out=ass.assfile.00:), misaligned milliseconds (.7instead of.07), and raw HTML tags (<i>).0:), correctly padded milliseconds (.07), and ASS override tags ({\i1}).Description
This PR resolves several compliance issues with the Substation Alpha (SSA/ASS) output generated by CCExtractor, addressing the bugs reported in #2310.
Fixes included:
Timestamp Formatting
%02u) to a single unpadded digit (%u) in allDialogue:lines to comply with strict SSA parser expectations.12.07srendering as12.7s).CEA-608 Override Tag Generation
get_decoder_line_encoded()so that when outputting SSA, it emits valid SSA override tags directly (e.g.,{\i1},{\u1},{\c&H00FF00&}) instead of generating HTML tags (<i>,<u>,<font...>) that are technically invalid in SSA.ssa_cols) to file-scope inccx_encoders_helpers.cto ensure the emitted font colors stay safely synchronized with the tag-stack tracking logic.HTML-to-SSA Tag Translation (DVB/Teletext/708)
write_stringz_as_ssa()for subtitle formats that generate generic HTML-tagged C-strings upstream. This gracefully translates<i>,<u>,<b>, and<font color="#RRGGBB">into their respective SSA equivalents ({\i1},{\u1},{\b1},{\c&HBBGGRR&}) without breaking other format outputs that rely on the HTML representation.Fixes #2310.