Make FFmpeg MP4 diagnostics format-safe

[Guflly]

This routes FFmpeg MP4 diagnostic text through a literal %s format before calling mprint, so filenames and error text cannot be interpreted as format specifiers. It covers every diagnostic in the Rust MP4 demuxer and adds a regression case with %s%n in the message.

Tests:

• cargo check --manifest-path src/rust/Cargo.toml --tests
• focused format-contract test (1 passed)
• focused clippy check with warnings denied
• cargo fmt --manifest-path src/rust/Cargo.toml --all -- --check

Fixes #2312

[ccextractor-bot]

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 6077cf5...:

Report Name	Tests Passed
Broken	9/13
CEA-708	2/14
DVB	0/7
DVD	3/3
DVR-MS	2/2
General	22/27
Hardsubx	1/1
Hauppage	3/3
MP4	3/3
NoCC	10/10
Options	69/86
Teletext	0/21
WTV	12/13
XDS	31/34

Your PR breaks these cases:

• ccextractor --out=srt --latin1 611b4a9235...
• ccextractor --autoprogram --out=ttxt --latin1 1020459a86...
• ccextractor --datapid 5603 --autoprogram --out=srt --latin1 --teletext 85c7fc1ad7...
• ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2...
• ccextractor --autoprogram --out=ttxt --latin1 132d7df7e9...
• ccextractor --autoprogram --out=ttxt --latin1 99e5eaafdc...
• ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65...
• ccextractor --autoprogram --out=ttxt --latin1 01509e4d27...
• ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b...
• ccextractor --out=spupng c83f765c66...
• ccextractor --dru c83f765c66...
• ccextractor --startat 4 --endat 7 c83f765c66...
• ccextractor --codec dvbsub --out=spupng 85271be4d2...
• ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
• ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
• ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
• ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
• ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
• ccextractor --tpage 801 4e56e88ba4...
• ccextractor --tverbose 4e56e88ba4...
• ccextractor --teletext 4e56e88ba4...
• ccextractor --autoprogram --out=srt --latin1 4e56e88ba4...
• ccextractor --autoprogram --out=ttxt --latin1 c0d2fba8c0...
• ccextractor --autoprogram --out=ttxt --latin1 006fdc391a...
• ccextractor --autoprogram --out=ttxt --latin1 e92a1d4d2a...
• ccextractor --autoprogram --out=ttxt --latin1 b37ce60eb9...
• ccextractor --autoprogram --out=ttxt --latin1 7e4ebf7fd7...
• ccextractor --autoprogram --out=ttxt --latin1 9256a60e4b...
• ccextractor --autoprogram --out=ttxt --latin1 27d7a43dd6...
• ccextractor --autoprogram --out=ttxt --latin1 297a44921a...
• ccextractor --autoprogram --out=ttxt --latin1 efbe129086...
• ccextractor --autoprogram --out=ttxt --latin1 eae0077731...
• ccextractor --autoprogram --out=ttxt --latin1 e2e2b501e0...
• ccextractor --autoprogram --out=ttxt --latin1 8c1615c1a8...
• ccextractor --autoprogram --out=ttxt --latin1 c6407fb294...
• ccextractor --autoprogram --out=ttxt --latin1 --datets dcada745de...
• ccextractor --autoprogram --out=srt --latin1 --tpage 398 5d5838bde9...
• ccextractor --autoprogram --out=srt --latin1 --tpage 299 44c45593fb...
• ccextractor --autoprogram --out=srt --latin1 --tpage 299 b8c55aa2e9...
• ccextractor --autoprogram --out=srt --latin1 --teletext --tpage 398 3b276ad8bf...
• ccextractor --autoprogram --out=ttxt --latin1 b236a0590b...
• ccextractor --out=srt --latin1 f23a544ba8...
• ccextractor --autoprogram --out=srt --latin1 --ucla d037c7509e...
• ccextractor --autoprogram --out=srt --latin1 --ucla 7d3f25c32c...
• ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7f41299cc7...

NOTE: The following tests have been failing on the master branch as well as the PR:

• ccextractor --out=srt --latin1 --autoprogram 73d9313d64..., Last passed:

  Test 8738

• ccextractor --out=ttxt --latin1 001dd8cdf7..., Last passed:

  Test 8738

• ccextractor --out=srt --latin1 4d4e938ef6..., Last passed:

  Test 8738

• ccextractor --service 1 --out=txt --no-bom --no-rollup ea83ff7bcb..., Last passed:

  Test 8738

• ccextractor --service 1 --out=txt f17524b53f..., Last passed:

  Test 8738

• ccextractor --service 1 --out=txt 80848c45f8..., Last passed:

  Test 8738

• ccextractor --service 1 --out=txt --no-bom --no-rollup b5d6aad89f..., Last passed:

  Test 8738

• ccextractor --service 1[EUC-KR] --out=txt --no-rollup b5d6aad89f..., Last passed:

  Test 8738

• ccextractor --service 1 --out=srt da904de35d..., Last passed:

  Test 8738

• ccextractor --service 1 --out=sami da904de35d..., Last passed:

  Test 8738

• ccextractor --service 1[EUC-KR] b5d6aad89f..., Last passed:

  Test 8738

• ccextractor --service 1[EUC-KR] --no-rollup b5d6aad89f..., Last passed:

  Test 8738

• ccextractor --service all da904de35d..., Last passed:

  Test 8738

• ccextractor --service all[EUC-KR] b5d6aad89f..., Last passed:

  Test 8738

• ccextractor --service 1,2[UTF-8],3[EUC-KR],54 --out=txt da904de35d..., Last passed:

  Test 8738

• ccextractor --autoprogram --out=srt --latin1 f1422b8bfe..., Last passed:

  Test 9208

• ccextractor --autoprogram --out=srt --latin1 d41b53b504..., Last passed:

  Test 8738

• ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed:

  Test 8738

• ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed:

  Test 8738

• ccextractor --service 1 c83f765c66..., Last passed:

  Test 8738

• ccextractor --myth c83f765c66..., Last passed:

  Test 8738

• ccextractor --in=raw fb79021542..., Last passed:

  Test 8738

• ccextractor --mp4vidtrack 5df914ce77..., Last passed:

  Test 8738

• ccextractor --xmltv=3 --out=null 96efd279cf..., Last passed:

  Test 8738

• ccextractor --datapid 2310 --autoprogram --out=srt --latin1 e639e54550..., Last passed:

  Test 8738

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

[ccextractor-bot]

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit c328108...:

Report Name	Tests Passed
Broken	9/13
CEA-708	2/14
DVB	0/7
DVD	3/3
DVR-MS	2/2
General	22/27
Hardsubx	1/1
Hauppage	3/3
MP4	3/3
NoCC	10/10
Options	69/86
Teletext	0/21
WTV	12/13
XDS	31/34

Your PR breaks these cases:

• ccextractor --out=srt --latin1 611b4a9235...
• ccextractor --autoprogram --out=ttxt --latin1 1020459a86...
• ccextractor --datapid 5603 --autoprogram --out=srt --latin1 --teletext 85c7fc1ad7...
• ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2...
• ccextractor --autoprogram --out=ttxt --latin1 132d7df7e9...
• ccextractor --autoprogram --out=ttxt --latin1 99e5eaafdc...
• ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65...
• ccextractor --autoprogram --out=ttxt --latin1 01509e4d27...
• ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b...
• ccextractor --out=spupng c83f765c66...
• ccextractor --dru c83f765c66...
• ccextractor --startat 4 --endat 7 c83f765c66...
• ccextractor --codec dvbsub --out=spupng 85271be4d2...
• ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
• ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
• ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
• ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
• ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
• ccextractor --tpage 801 4e56e88ba4...
• ccextractor --tverbose 4e56e88ba4...
• ccextractor --teletext 4e56e88ba4...
• ccextractor --autoprogram --out=srt --latin1 4e56e88ba4...
• ccextractor --autoprogram --out=ttxt --latin1 c0d2fba8c0...
• ccextractor --autoprogram --out=ttxt --latin1 006fdc391a...
• ccextractor --autoprogram --out=ttxt --latin1 e92a1d4d2a...
• ccextractor --autoprogram --out=ttxt --latin1 b37ce60eb9...
• ccextractor --autoprogram --out=ttxt --latin1 7e4ebf7fd7...
• ccextractor --autoprogram --out=ttxt --latin1 9256a60e4b...
• ccextractor --autoprogram --out=ttxt --latin1 27d7a43dd6...
• ccextractor --autoprogram --out=ttxt --latin1 297a44921a...
• ccextractor --autoprogram --out=ttxt --latin1 efbe129086...
• ccextractor --autoprogram --out=ttxt --latin1 eae0077731...
• ccextractor --autoprogram --out=ttxt --latin1 e2e2b501e0...
• ccextractor --autoprogram --out=ttxt --latin1 8c1615c1a8...
• ccextractor --autoprogram --out=ttxt --latin1 c6407fb294...
• ccextractor --autoprogram --out=ttxt --latin1 --datets dcada745de...
• ccextractor --autoprogram --out=srt --latin1 --tpage 398 5d5838bde9...
• ccextractor --autoprogram --out=srt --latin1 --tpage 299 44c45593fb...
• ccextractor --autoprogram --out=srt --latin1 --tpage 299 b8c55aa2e9...
• ccextractor --autoprogram --out=srt --latin1 --teletext --tpage 398 3b276ad8bf...
• ccextractor --autoprogram --out=ttxt --latin1 b236a0590b...
• ccextractor --out=srt --latin1 f23a544ba8...
• ccextractor --autoprogram --out=srt --latin1 --ucla d037c7509e...
• ccextractor --autoprogram --out=srt --latin1 --ucla 7d3f25c32c...
• ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 7f41299cc7...

NOTE: The following tests have been failing on the master branch as well as the PR:

• ccextractor --out=srt --latin1 --autoprogram 73d9313d64..., Last passed:

  Test 8611

• ccextractor --out=ttxt --latin1 001dd8cdf7..., Last passed:

  Test 8611

• ccextractor --out=srt --latin1 4d4e938ef6..., Last passed:

  Test 8611

• ccextractor --service 1 --out=txt --no-bom --no-rollup ea83ff7bcb..., Last passed:

  Test 8611

• ccextractor --service 1 --out=txt f17524b53f..., Last passed:

  Test 8611

• ccextractor --service 1 --out=txt 80848c45f8..., Last passed:

  Test 8611

• ccextractor --service 1 --out=txt --no-bom --no-rollup b5d6aad89f..., Last passed:

  Test 8611

• ccextractor --service 1[EUC-KR] --out=txt --no-rollup b5d6aad89f..., Last passed:

  Test 8611

• ccextractor --service 1 --out=srt da904de35d..., Last passed:

  Test 8611

• ccextractor --service 1 --out=sami da904de35d..., Last passed:

  Test 8611

• ccextractor --service 1[EUC-KR] b5d6aad89f..., Last passed:

  Test 8611

• ccextractor --service 1[EUC-KR] --no-rollup b5d6aad89f..., Last passed:

  Test 8611

• ccextractor --service all da904de35d..., Last passed:

  Test 8611

• ccextractor --service all[EUC-KR] b5d6aad89f..., Last passed:

  Test 8611

• ccextractor --service 1,2[UTF-8],3[EUC-KR],54 --out=txt da904de35d..., Last passed:

  Test 8611

• ccextractor --autoprogram --out=srt --latin1 f1422b8bfe..., Last passed:

  Test 9209

• ccextractor --autoprogram --out=srt --latin1 d41b53b504..., Last passed:

  Test 8611

• ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed:

  Test 8611

• ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed:

  Test 8611

• ccextractor --service 1 c83f765c66..., Last passed:

  Test 8611

• ccextractor --myth c83f765c66..., Last passed:

  Test 8611

• ccextractor --in=raw fb79021542..., Last passed:

  Test 8611

• ccextractor --mp4vidtrack 5df914ce77..., Last passed:

  Test 8611

• ccextractor --xmltv=3 --out=null 96efd279cf..., Last passed:

  Test 8611

• ccextractor --datapid 2310 --autoprogram --out=srt --latin1 e639e54550..., Last passed:

  Test 8611

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.