HPCDATAMGM-2192: Removing unnecessary multipart/form-data.#177
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes unnecessary multipart/form-data encoding from non-file-upload forms in the hpc-web Thymeleaf templates to reduce form payload size and avoid 413 errors on large submissions.
Changes:
- Removed multipart encoding from bulk permission/metadata, notification, report, criteria, and search-result forms.
- Kept multipart usage limited to actual file upload templates.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/hpc-web/src/main/resources/templates/updatemetadatabulk.html |
Uses default form encoding for bulk metadata updates. |
src/hpc-web/src/main/resources/templates/subscribenotifications.html |
Uses default form encoding for notification subscriptions. |
src/hpc-web/src/main/resources/templates/reports.html |
Uses default form encoding for reports form submission. |
src/hpc-web/src/main/resources/templates/permissionbulk.html |
Uses default form encoding for bulk permissions. |
src/hpc-web/src/main/resources/templates/dataobjectsearchresultdetail.html |
Uses default form encoding for search result action forms. |
src/hpc-web/src/main/resources/templates/dataobjectsearchresult.html |
Uses default form encoding for search result action forms. |
src/hpc-web/src/main/resources/templates/criteria.html |
Uses default form encoding for search criteria submission. |
src/hpc-web/src/main/resources/templates/collectionsearchresultdetail.html |
Uses default form encoding for collection search result action forms. |
src/hpc-web/src/main/resources/templates/collectionsearchresult.html |
Uses default form encoding for collection search result action forms. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
menons
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In collection permission page, adding new users to permissions list when the list gets long resulted in "HTTP - 413 Payload Too Large" Error. This was resolved and tested. The following form submission also does not need to use multipart/form-data and therefore was removed.