Skip to content

macOS support#147

Merged
ggutierrez-sunbright merged 8 commits intoCBDD:mainfrom
chdominguez:macos_support
Feb 18, 2025
Merged

macOS support#147
ggutierrez-sunbright merged 8 commits intoCBDD:mainfrom
chdominguez:macos_support

Conversation

@chdominguez
Copy link
Contributor

@chdominguez chdominguez commented Feb 13, 2025

Dear rDock members, we are developing an unofficial rDock plugin for Horus at the Barcelona Supercomputing Center. You can learn more about Horus in the official webpage.

Horus natively supports Linux and macOS and we wanted to distribute the plugin for both platforms. In order to do so, I had to compile rDock on macOS manually. For it to work I had to slightly modify some parts of the code and the makefiles.

During my tests, I did not see any change in the results outputs and the application is working flawlessly. I hope that this macOS support allows rDock to run on more platforms!

@ggutierrez-sunbright
Copy link
Contributor

Hi!
First of all, thanks for the contribution. osx support has been one of those things in my wish-list for a while : )

I have some questions (mostly out of curiosity, it's been a while since the last time I used a mac) and suggestions, I'll write them along the relevant lines

Thanks again and regards

Guillermo

README.md Outdated
Comment on lines +52 to +55
on `macOS`, you may need to run `export CC=gcc` before running make in order to use gcc instead of clang. Here is an example for gcc-14 installed with homebrew:

```
export CC=/opt/homebrew/Cellar/gcc/14.2.0_1/bin/gcc-14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to export CC as well? I don't think it's being used in the makefile directly.
also, are there issues with clang? in linux it is supported as a compiler

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, only CXX is needed.

About the compiler: yes, because Apple's clang is more restrictive as there are some libraries that need to be imported differently (if I recall correctly it's about the import order). GCC does not have that problem and before changing the codebase I preferred to use a different compiler.

@ggutierrez-sunbright ggutierrez-sunbright self-assigned this Feb 14, 2025
chdominguez and others added 3 commits February 15, 2025 12:36
Co-authored-by: ggutierrez <94693768+ggutierrez-sunbright@users.noreply.github.com>
@ggutierrez-sunbright
Copy link
Contributor

(closes #150 )

@ggutierrez-sunbright ggutierrez-sunbright merged commit 3e631b5 into CBDD:main Feb 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants