Conversation
This change removes all invocations of the deprecated mysql_* APIs and replaces them with mysqli calls instead. Configuration in includes/mysql.php is now instrumented via environment variables. The application will not start if mandatory environment variables are not defined. Missing environment variables are logged to the PHP/Apache error log. Input validation in the autocomplete backend in www/ac.php has been fixed. The database connection is no longer stored in the session as it is only valid for a single request and had not been reused before either. Some TODO tags have been added at places in the code that need rework. Add TODO.md and changelog.md as well as setup instructions in README.md.
|
This PR needs to be deployed on a test system before putting it in production. I tested the regular user functionality in a local docker-compose setup. Code for the docker-compose setup is available in https://git.dittberner.info/jan/cacert-devsetup |
The environment variables containing MYSQL_APP have been renamed to MYSQL_WEBDB to be consistent with the developer setup and to avoid confusion with the test manager and CATS applications. The ancient includes/.cvsignore file has been removed to avoid confusion in IDEs. URLs are now built consistently using the environment variables.
bdmc
left a comment
bdmc
left a comment
There was a problem hiding this comment.
That was a BIG PR.
Although I would prefer the "long" tag ( <?php ) instead of the short, I agree with all of your changes.
I did notice that you corrected one spelling error in consistence.php, but saw a couple of other, similar, ones.
Brian
|
How does this relate to the work done by GuKKDevel in branch-1442? |
|
@Ted-CAcert the branches are not related. GuKKDevel just replaced |
|
So your changes would obsolete the (current) changes of bug-1442? This is good to know. I'll have to have a closer look... |
3 participants
No description provided.