Skip to content

Fix BKT params naming: use defaultBKTParams and experimentalBKTParams #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allyqwert merged 1 commit into from
Feb 17, 2026
Merged

Fix BKT params naming: use defaultBKTParams and experimentalBKTParams #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/deploy-content-staging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ jobs:
cd content-staging-build/src/content-sources/oatutor
mv "OpenStax Content" "content-pool"
mkdir -p bkt-params
mv bktParams.json bkt-params/bktParams1.json
cp bkt-params/bktParams1.json bkt-params/bktParams2.json
mv bktParams.json bkt-params/defaultBKTParams.json
cp bkt-params/defaultBKTParams.json bkt-params/experimentalBKTParams.json

- name: Run Node.js preprocessing script
run: |
Expand Down
8 changes: 4 additions & 4 deletions src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ import TabFocusTrackerWrapper from "./components/TabFocusTrackerWrapper";
// ### BEGIN CUSTOMIZABLE IMPORTS ###
import config from "./config/firebaseConfig.js";
import skillModel from "./content-sources/oatutor/skillModel.json";
import bktParams1 from "./content-sources/oatutor/bkt-params/bktParams1.json";
import bktParams2 from "./content-sources/oatutor/bkt-params/bktParams2.json";
import defaultBKTParams from "./content-sources/oatutor/bkt-params/defaultBKTParams.json";
import experimentalBKTParams from "./content-sources/oatutor/bkt-params/experimentalBKTParams.json";
import { heuristic as lowestHeuristic } from "./models/BKT/problem-select-heuristics/problemSelectHeuristic1.js";
import { heuristic as highestHeuristic } from "./models/BKT/problem-select-heuristics/problemSelectHeuristic2.js";
import BrowserStorage from "./util/browserStorage";
Expand All @@ -61,8 +61,8 @@ const queryParamsToKeep = ["use_expanded_view", "to", "do_not_restore"];

const treatmentMapping = {
bktParams: {
0: cleanObjectKeys(bktParams1),
1: cleanObjectKeys(bktParams2),
0: cleanObjectKeys(defaultBKTParams),
1: cleanObjectKeys(experimentalBKTParams),
},
heuristic: {
0: lowestHeuristic,
Expand Down