Skip to content

Add missing asserts to test_grid_manager.py#1242

Open
msimberg wants to merge 1 commit intoC2SM:mainfrom
msimberg:fix-missing-assert-test-grid-manager
Open

Add missing asserts to test_grid_manager.py#1242
msimberg wants to merge 1 commit intoC2SM:mainfrom
msimberg:fix-missing-assert-test-grid-manager

Conversation

@msimberg
Copy link
Copy Markdown
Contributor

@msimberg msimberg commented May 6, 2026

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • cscs-ci run distributed

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark-bencher

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:

  • cscs-ci run extra

For more detailed information please look at CI in the EXCLAIM universe.

@msimberg
Copy link
Copy Markdown
Contributor Author

msimberg commented May 6, 2026

cscs-ci run default

@msimberg
Copy link
Copy Markdown
Contributor Author

msimberg commented May 6, 2026

cscs-ci run distributed

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a unit test that previously computed np.allclose(...) results without asserting them, ensuring the E2C2E/E2C2EO connectivity checks actually fail when mismatched.

Changes:

  • Add missing assert statements around np.allclose(...) in test_grid_manager_eval_e2c2e.
  • Ensures the sliced connectivity comparison (from start_index onward) is enforced by pytest.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants