Add Python 3.14 support, upgrade uv.lock by Copilot · Pull Request #1197 · C2SM/icon4py

Copilot · 2026-04-15T09:31:33Z

Add compatibility for python 3.14. GitHub workflows test 3.10 and 3.13. The CSCS CI workflows test with 3.13.

Also updates the uv lock file, which updates a lot of packages. Among others, the new ruff version has more checks and changes formatting in a few places.

jenkins-apn · 2026-04-15T09:31:37Z

Hi there, this is jenkins continuous integration...
Do you want me to verify this patch?

jenkins-apn · 2026-04-15T09:31:38Z

Hi there, this is jenkins continuous integration...
Do you want me to verify this patch?

Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/67a16ff8-8720-433f-920e-854496654e2c Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

…-packages

Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/603e50df-ddcc-4efa-a6a0-241b9d492e8b Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/1404233a-0a05-4f64-b64b-2f77e3871544 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

msimberg · 2026-04-29T12:19:50Z

cscs-ci run default

msimberg · 2026-04-29T13:32:53Z

cscs-ci run distributed

msimberg · 2026-04-29T14:16:39Z

Exactly which versions to test and where is still an open question, but I think this might be ready for at least an initial review. @egparedes I requested one from you if you have time since I'm guessing you might be more familiar with different python versions. The biggest change comes from trying to use the new type keyword, which is not a must in this PR, but I've applied it where possible.

msimberg · 2026-05-06T07:42:29Z

I got a bit overly excited with this PR. I'll make this PR focus on adding python 3.14 support and move the bump to 3.12 as minimum to a follow-up PR.

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>

msimberg · 2026-05-06T15:30:36Z

cscs-ci run default

msimberg · 2026-05-07T10:07:27Z

cscs-ci run default

msimberg · 2026-05-07T10:07:31Z

cscs-ci run distributed

github-actions · 2026-05-07T10:21:09Z

Mandatory Tests

Please make sure you run these tests via comment before you merge!

cscs-ci run default
cscs-ci run distributed

Optional Tests

To run benchmarks you can use:

cscs-ci run benchmark-bencher

To run tests and benchmarks with the DaCe backend you can use:

cscs-ci run dace

To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:

cscs-ci run extra

For more detailed information please look at CI in the EXCLAIM universe.

msimberg · 2026-05-07T10:21:09Z

cscs-ci run default

msimberg · 2026-05-07T12:41:17Z

cscs-ci run distributed

egparedes

Mostly nitpcking. LGTM

egparedes · 2026-05-08T06:05:49Z

        """

-        import pymetis  # type: ignore [import-untyped]
+        import pymetis  # noqa: PLC0415


Due to our coding conventions: https://github.com/C2SM/icon4py/blob/main/CODING_GUIDELINES.md#ignoring-qa-errors

Suggested change

import pymetis # noqa: PLC0415

import pymetis # noqa: PLC0415 [import-outside-top-level]

egparedes · 2026-05-08T06:08:17Z


 def init_mpi() -> None:
-    from mpi4py import MPI
+    from mpi4py import MPI  # noqa: PLC0415


Suggested change

from mpi4py import MPI # noqa: PLC0415

from mpi4py import MPI # noqa: PLC0415 [import-outside-top-level]

egparedes · 2026-05-08T06:08:27Z


 def finalize_mpi() -> None:
-    from mpi4py import MPI
+    from mpi4py import MPI  # noqa: PLC0415


Suggested change

from mpi4py import MPI # noqa: PLC0415

from mpi4py import MPI # noqa: PLC0415 [import-outside-top-level]

egparedes · 2026-05-08T06:10:11Z

        attrs = {}
    dims = tuple(dimension_mapping(d, is_on_interface) for d in field.domain.dims)
-    horizontal_dim = next(filter(lambda d: _is_horizontal(d), field.domain.dims))
+    horizontal_dim = next(filter(_is_horizontal, field.domain.dims))


Nitpicking, but list comprehensions are more idiomatic in python than map and filter

Suggested change

horizontal_dim = next(filter(_is_horizontal, field.domain.dims))

horizontal_dim = next(d for d in field.domain.dims if _is_horizontal(d))

egparedes · 2026-05-08T06:21:00Z

+        obj = self._func
+        while hasattr(obj, "__wrapped__") or isinstance(obj, functools.partial):
+            obj = getattr(obj, "__wrapped__", None) or obj.func


Optional nitpicking, feel free to ignore

Suggested change

obj = self._func

while hasattr(obj, "__wrapped__") or isinstance(obj, functools.partial):

obj = getattr(obj, "__wrapped__", None) or obj.func

obj = inspect.unwrap(self._func)

while isinstance(obj, functools.partial):

obj = inspect.unwrap(obj.func)

egparedes · 2026-05-08T06:27:47Z

            )

-        from icon4py.model.common.decomposition.mpi_decomposition import init_mpi
+        from icon4py.model.common.decomposition.mpi_decomposition import init_mpi  # noqa: PLC0415


Suggested change

from icon4py.model.common.decomposition.mpi_decomposition import init_mpi # noqa: PLC0415

from icon4py.model.common.decomposition.mpi_decomposition import init_mpi # noqa: PLC0415 [import-outside-top-level]

egparedes · 2026-05-08T06:28:12Z


 def load_gt4py_timers(filename: pathlib.Path, metric: str) -> tuple[dict, dict]:
-    import numpy as np
+    import numpy as np  # noqa: PLC0415


Missing error codes in noqas

egparedes · 2026-05-08T06:28:41Z

        # if needed in the future.

-        from icon4py.model.testing import (
+        from icon4py.model.testing import (  # noqa: PLC0415


Suggested change

from icon4py.model.testing import ( # noqa: PLC0415

from icon4py.model.testing import ( # noqa: PLC0415 [import-outside-top-level]

egparedes · 2026-05-08T06:28:55Z

 def get_validation_grids() -> list[definitions.GridDescription]:
-    from icon4py.model.testing import definitions  # Import here to reduce startup time of the CLI
+    # Import here to reduce startup time of the CLI
+    from icon4py.model.testing import definitions  # noqa: PLC0415


Missing error codes in noqas

egparedes · 2026-05-08T06:29:04Z

 @pytest.fixture
 def ffi():
-    import cffi
+    import cffi  # noqa: PLC0415


Missing error codes in noqas

Initial plan

d2dd1fa

Copilot AI assigned Copilot and msimberg Apr 15, 2026

Copilot started work on behalf of msimberg April 15, 2026 09:31 View session

Copilot AI linked an issue Apr 15, 2026 that may be closed by this pull request

Update locked packages #1163

Open

ci: add python 3.14 POC coverage for github and cscs pipelines

58f863c

Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/67a16ff8-8720-433f-920e-854496654e2c Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Update locked packages and add Python 3.14 testing~~ Add Python 3.14 POC coverage across GitHub and CSCS CI pipelines Apr 15, 2026

Copilot finished work on behalf of msimberg April 15, 2026 09:43

Copilot AI requested a review from msimberg April 15, 2026 09:43

Copilot started work on behalf of msimberg April 15, 2026 10:12 View session

Copilot finished work on behalf of msimberg April 15, 2026 10:16

Merge remote-tracking branch 'origin/main' into copilot/update-locked…

3056b8f

…-packages

msimberg force-pushed the copilot/update-locked-packages branch from f524288 to 3056b8f Compare April 15, 2026 10:32

Update lockfile

bf87f58

Copilot started work on behalf of msimberg April 15, 2026 10:37 View session

Update uv version to 0.11.6 in test workflows to get Python 3.14 stable

f850935

Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/603e50df-ddcc-4efa-a6a0-241b9d492e8b Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

Copilot finished work on behalf of msimberg April 15, 2026 11:00

Copilot started work on behalf of msimberg April 15, 2026 12:08 View session

Changes before error encountered

7088d09

Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/1404233a-0a05-4f64-b64b-2f77e3871544 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>

msimberg added 8 commits April 20, 2026 20:48

Formatting with newer ruff

29cf67c

Ignore deferred imports

9febac5

Simplify unnecessary lambdas

e489492

Ignore deferred imports

56a0555

Define EARTH_RADIUS only once

d01a519

Ignore warning about hash being disabled

fa57866

linting

e709c11

Update uv.lock

f3667ac

Fix more type alias issues

5a35130

msimberg requested a review from egparedes April 29, 2026 14:15

msimberg marked this pull request as ready for review April 29, 2026 14:15

msimberg added 4 commits April 30, 2026 13:02

Merge branch 'origin/main' into copilot/update-locked-packages

d2d6a0c

Merge branch 'main' into copilot/update-locked-packages

4c92975

Fix linter issues after merge

b81f462

Format uv.lock

1564f0b

Keep only python 3.12-3.14 required changes, don't bump minium version

5925c3b

msimberg changed the title ~~Add Python 3.14 support and bump minimum version to 3.12~~ Add Python 3.14 support, upgrade uv.lock May 6, 2026

msimberg added 3 commits May 6, 2026 14:25

Merge branch 'main' into copilot/update-locked-packages

98f638d

Fix lint and type issues after merge from main

583b7f2

Fix UP038 isinstance call

88ffe0b

msimberg reviewed May 6, 2026

View reviewed changes

Comment thread tools/src/icon4py/tools/py2fgen/runtime_config.py Outdated

msimberg reviewed May 6, 2026

View reviewed changes

Comment thread tools/src/icon4py/tools/py2fgen/runtime_config.py

msimberg reviewed May 6, 2026

View reviewed changes

Comment thread tools/src/icon4py/tools/py2fgen/runtime_config.py

Apply suggestions from code review

d25bef0

Co-authored-by: Mikael Simberg <mikael.simberg@iki.fi>

msimberg mentioned this pull request May 6, 2026

Bump minimum supported python to 3.12 #1248

Draft

Update lockfile again

27197df

Add one more noqa

f798395

egparedes approved these changes May 8, 2026

View reviewed changes

	import pymetis # noqa: PLC0415
	import pymetis # noqa: PLC0415 [import-outside-top-level]

	from mpi4py import MPI # noqa: PLC0415
	from mpi4py import MPI # noqa: PLC0415 [import-outside-top-level]

	horizontal_dim = next(filter(_is_horizontal, field.domain.dims))
	horizontal_dim = next(d for d in field.domain.dims if _is_horizontal(d))

	from icon4py.model.common.decomposition.mpi_decomposition import init_mpi # noqa: PLC0415
	from icon4py.model.common.decomposition.mpi_decomposition import init_mpi # noqa: PLC0415 [import-outside-top-level]

	from icon4py.model.testing import ( # noqa: PLC0415
	from icon4py.model.testing import ( # noqa: PLC0415 [import-outside-top-level]

Conversation

Copilot AI commented Apr 15, 2026 • edited by msimberg Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jenkins-apn commented Apr 15, 2026

Uh oh!

jenkins-apn commented Apr 15, 2026

Uh oh!

msimberg commented Apr 29, 2026

Uh oh!

msimberg commented Apr 29, 2026

Uh oh!

msimberg commented Apr 29, 2026

Uh oh!

msimberg commented May 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

msimberg commented May 6, 2026

Uh oh!

msimberg commented May 7, 2026

Uh oh!

msimberg commented May 7, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

msimberg commented May 7, 2026

Uh oh!

msimberg commented May 7, 2026

Uh oh!

egparedes left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Apr 15, 2026 •

edited by msimberg

Loading