Enable mypy checking for the previously excluded microphysics directory#1196
Enable mypy checking for the previously excluded microphysics directory#1196
Conversation
|
Hi there, this is jenkins continuous integration... |
1 similar comment
|
Hi there, this is jenkins continuous integration... |
Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/319d6d9c-529a-4426-88da-181a1539b4d6 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>
| # '$MYPY_CONFIG_FILE_DIR/model/atmosphere/dycore/src', | ||
| '$MYPY_CONFIG_FILE_DIR/model/atmosphere/dycore/tests/', | ||
| # '$MYPY_CONFIG_FILE_DIR/model/atmosphere/subgrid_scale_physics/microphysics/src', | ||
| '$MYPY_CONFIG_FILE_DIR/model/atmosphere/subgrid_scale_physics/microphysics/src/icon4py/model/atmosphere/subgrid_scale_physics/microphysics/microphysics_options.py', |
There was a problem hiding this comment.
@copilot try to enable the full '$MYPY_CONFIG_FILE_DIR/model/atmosphere/subgrid_scale_physics/microphysics/src' directory instead of just one file.
There was a problem hiding this comment.
Updated in commit 0749a77: the mypy target now enables the full '$MYPY_CONFIG_FILE_DIR/model/atmosphere/subgrid_scale_physics/microphysics/src' directory instead of a single file.
There was a problem hiding this comment.
@copilot Try to enable the microphysics/test directory as well (just do the parent microphysics directory in one go).
There was a problem hiding this comment.
Done in commit 95cea5b: switched the mypy target to the parent '$MYPY_CONFIG_FILE_DIR/model/atmosphere/subgrid_scale_physics/microphysics' so src and tests are enabled together. (No UI changes; config-only update.)
Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/4f9f8dab-e3a0-4da0-926d-0517bcd35203 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>
Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/42dcf59c-f146-4c96-9c04-7f2dce9a86b4 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>
Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/42dcf59c-f146-4c96-9c04-7f2dce9a86b4 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>
…checking-coverage Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>
Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/5a5ec877-e2e7-44ad-a877-6c8225cf2ad8 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>
Agent-Logs-Url: https://github.com/C2SM/icon4py/sessions/9de2e124-3c32-4539-b8e0-2daebb2517f3 Co-authored-by: msimberg <42977+msimberg@users.noreply.github.com>
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
|
|
||
|
|
||
| @gtx.scan_operator( | ||
| @gtx.scan_operator( # type: ignore[call-overload] # gt4py stubs don't support tuple init |
There was a problem hiding this comment.
@DropD does this ignore fit limitations on type checking of gt4py programs?
| mphys_options.LiquidAutoConversionType.KESSLER | ||
| ) | ||
| liquid_autoconversion_option: gtx.int32 = mphys_options.LiquidAutoConversionType.KESSLER | ||
| #: snow size distribution interception parameter. Originally defined as isnow_n0temp (PARAMETER) in gscp_data.f90 in ICON. I keep it because I think the choice depends on resolution. |
There was a problem hiding this comment.
To do: check this change.
There was a problem hiding this comment.
These gtx.int32 may go away with #1202? Come back to this once a few of the frozen namespace PRs are merged.
No description provided.