Deploy: Add Terraform configuration and infrastructure setup for Digital Ocean#8
Merged
ByteMeDirk merged 5 commits intomainfrom Jun 5, 2025
Merged
Deploy: Add Terraform configuration and infrastructure setup for Digital Ocean#8ByteMeDirk merged 5 commits intomainfrom
ByteMeDirk merged 5 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Terraform-based infrastructure setup for Digital Ocean, extracts API key retrieval into a dedicated function, and updates related documentation and CI tooling.
- Add Terraform configuration files (main.tf, variables.tf, database.tf, outputs.tf) and example tfvars
- Extract
get_newsapi_keyfromget_db_configinenv.py - Update documentation (INFRASTRUCTURE.md, DEPLOYMENT.md, README.md) and streamline CI configs
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| semantic_medallion_data_platform/config/env.py | Move NewsAPI key retrieval into its own function |
| infrastructure/terraform/variables.tf | Define variables for Digital Ocean provider |
| infrastructure/terraform/terraform.tfvars.example | Provide example tfvars for user configuration |
| infrastructure/terraform/outputs.tf | Define Terraform outputs for DB connection details |
| infrastructure/terraform/main.tf | Configure Terraform provider for Digital Ocean |
| infrastructure/terraform/database.tf | Define PostgreSQL resources on Digital Ocean |
| docs/INFRASTRUCTURE.md | Document Terraform setup and resources |
| docs/DEPLOYMENT.md | Document deployment steps including Terraform and app setup |
| README.md | Add Terraform setup section and update tech stack |
| .pre-commit-config.yaml | Comment out large file check in pre-commit hooks |
| .github/workflows/pr-tests.yml | Add GitHub Actions workflow for PR tests |
| .github/workflows/ci-cd.yml | Remove deprecated CI/CD pipeline file |
Files not reviewed (1)
- infrastructure/terraform/.terraform.lock.hcl: Language not supported
Comments suppressed due to low confidence (2)
README.md:33
- The README references a
setup.shscript underinfrastructure/terraform/that isn't present in the repo. Either add the script or remove the entry.
│ └── terraform/ # Terraform configuration for Digital Ocean
infrastructure/terraform/terraform.tfvars.example:12
- [nitpick] The example uses
semantic-data-platformwith dashes, but the defaultproject_nameisSemantic Data Platform. Align naming formats to avoid confusion.
# project_name = "semantic-data-platform"
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.