Flush all (from header menu) now flushes all WPML registered domains too #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my clients was using this plugin but also had WPML activated and runs two domains on your servers: *.nl & *.de. Using the flush all button on top of the WP admin, only the *.nl got flushed due to the usage of home_url(). I changed things a bit to be able to use all WPML registered domains also in the flush all function.
I didn't adjust other functions yet, but clearly there are more places that could use this change as I see more usage of home_url(). Problem is that e.g. at Post Observer you also need to figure out which domain the post belongs to and use the correct URL for it to register. Option could be to implement at any flush all the registered domains ofcourse.
For now this is the fix that suits my client and I hope you can also use it.