[data] feat: add MultiSourceDataset for weighted sampling#522
Draft
[data] feat: add MultiSourceDataset for weighted sampling#522
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces MultiSourceDataset for weighted sampling from multiple data sources and enhances DynamicBatchingSizeDataset with stateful multi-worker support, both with robust checkpointing capabilities. The changes are well-tested and significantly improve data handling flexibility. My main feedback concerns the use of a broad exception in the MoE merging script, which could mask underlying issues. I've suggested a more specific exception handling approach to improve the script's robustness.
…_exhausted strategy
c6d3fc0 to
cca36ef
Compare
LiuzcEECS
reviewed
Feb 28, 2026
LiuzcEECS
reviewed
Feb 28, 2026
2863b77 to
1268cc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR includes multiple features and fixes merged from the feature branch:
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includemisc,ci,config,docs,data,dist,omni,logging,model,optim,ckpt,release,task,perf,ops,parallel,like[ci, data, model]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][parallel, model] feat: dynamic batchingTest
API and Usage Example
Design & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=always