fix(caching): avoid redundant computations during caching - #307
Open
GoshaSerbin wants to merge 1 commit into
Open
fix(caching): avoid redundant computations during caching#307GoshaSerbin wants to merge 1 commit into
GoshaSerbin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an inefficiency in the caching implementation caused by residuals not being utilized during cached inference.
Each model layer maintains its own cache and predicts features using the Taylor approximation, incurring both additional memory usage (storing previous timesteps) and extra computation. However, since residuals are not utilized during caching, the output of previous layers does not influence subsequent layers. As a result, maintaining caches for intermediate layers provides no benefit.
This change removes the unnecessary caching overhead for all layers except the final layer while preserving identical outputs.
Performance
Profiling with
max_order=6:Results
Implementation
The optimization skips cache maintenance for all intermediate layers and keeps it only for the final layer. This is possible because intermediate layer caches are never utilized during cached inference.