Skip to content

Fixed "Locking does not work"#100

Open
tankist1337 wants to merge 1 commit intoBuuz135:1.21from
tankist1337:fix_filter_ignoring
Open

Fixed "Locking does not work"#100
tankist1337 wants to merge 1 commit intoBuuz135:1.21from
tankist1337:fix_filter_ignoring

Conversation

@tankist1337
Copy link

Filter doesn't work at all because LockableMatterTankBundle ignores the previous state of filter in NBT LockableMatterTankBundle creates a new NBT based on isEmpty.

  1. LockableMatterTankBundle.serializeNBT() ->
  2. compoundNBT.put("Filter", this.filter.writeToNBT(new CompoundTag())); ->
  3. nbt.putString("MatterName", ReplicationRegistry.MATTER_TYPES_REGISTRY.get().getKey(getMatterType()).toString()); ->
  4. isEmpty ? MatterType.EMPTY : matter;

(matter = Earth, isEmpty = true => returns MatterType.EMPTY)

@tankist1337
Copy link
Author

#90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant