-
Notifications
You must be signed in to change notification settings - Fork 20
update args files with latest args #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: extension
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Details
But they both do the same! Both execute function But why in the first case we have error, and in the second is not? Difference: [1] When running [2] When running Returning to this extension. There's two solutions
and |
Ohhhh yesss! Also foundry making this changes not allowing script contracts addresses to be used makes sense! TYSM Rinat for explanation and the fix 🙌 Once we release the create-eth new version |
rin-st
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Lgtm!
Description:
Updated the extension inline with latest args
Hardhat works nicely but with
foundryencountered an error while challenges deployement:Error
I think we encountered a similar error here scaffold-eth/create-eth#312 but with the verification script, now it is happening with the Deploy script...cc @rin-st if you can spot something easily? (not urgent! will also try to debug it on wednesday, just tagged incase you can easily spot)
I tried running
npx create-eth@latest -s foundryand there deployments works nicely withYourContract.sol