-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Refactoring/mifare keys handling #1990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Senape3000
wants to merge
20
commits into
BruceDevices:dev
Choose a base branch
from
Senape3000:Refactoring/Mifare-Keys
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+352
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This document provides a comprehensive technical overview of SRIX and ST25TB contactless RFID memory chips, detailing their features, operating conditions, memory organization, command set, and application patterns.
Add custom documentation directory to .gitignore
Added a comprehensive README for the RFID JavaScript API, detailing features, usage, and implementation.
Updated RFID API documentation to reflect new features, including headless operation and enhanced JavaScript bindings.
Updated the README to include author information and credits, and modified the status of supported modules.
Updated README to include development goals and installation instructions.
Added a comprehensive refactoring report for MIFARE keys management, detailing the separation of key storage, new file structure, technical implementation, benefits, and testing checklist.
Refactor MIFARE key handling to load from a separate file and validate keys. Remove old MIFARE key handling code and ensure keys are appended correctly.
Draft
Use external mifare keys manager
Updated for use mifare_keys_manager, external file for better code organization
external manager for mifare keys management
Contributor
Author
|
Rewritten, the old version took up unnecessary space in config, now it's cleaner, more maintainable and clear. It has fallbacks for various eventualities. Already tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Refactored MIFARE keys management by separating storage from main config (
bruce.conf) into dedicated file (/BruceRFID/keys.conf). Fixes SD card path bug and improves performance with human-readable format.Types of Changes
Verification
/BruceRFID/keys.confwith 3 standard keysTesting
✅ Full testing completed ([file:19]):
Linked Issues
Resolves SD card path bug where keys file was created in root instead of
/BruceRFID/directory.User-Facing Change