Remove minimum voting power requirement #176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove minRequiredVotingPower state variable and related checks - Remove BelowMinRequiredVotingPower error - Remove setMinRequiredVotingPower function - Add _initialOwner parameter to initialize function and call __VotingMultipliers_init - Update deploy scripts and test configs This allows all BREAD holders to vote regardless of their balance, preventing the getVotingPower function from returning 0 for users with small but non-zero voting power.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
minRequiredVotingPowerstate variable and related checks incastVoteandcastVoteWithMultipliersBelowMinRequiredVotingPowererror from the interfacesetMinRequiredVotingPoweradmin function_initialOwnerparameter toinitializefunction and call__VotingMultipliers_initto fix initialization (tests were failing because ownership wasn't set up)This allows all BREAD holders to vote regardless of their balance, fixing the issue where
getVotingPowerreturns 0 even when users have some voting power but below the minimum threshold.Test plan
BelowMinRequiredVotingPowerrevert