Add halfedge_tangents to MeshBoolImpl and MeshGL#6
Add halfedge_tangents to MeshBoolImpl and MeshGL#6JaminKoke wants to merge 2 commits intoBorgerLand:masterfrom
halfedge_tangents to MeshBoolImpl and MeshGL#6Conversation
18c883d to
84bae1f
Compare
Also add `MeshGL::halfedge_tangent` and `TransformTangents`
84bae1f to
754d5a8
Compare
|
I'm not very familiar with this feature, but when I search |
I'm not familiar with it either, and from what I can tell it does seem to be mostly related to smoothing and subdivision (I did not realize this and assumed it was necessary for other things).
Maybe, I did look over it again and saw that there were a handful of areas I missed porting.
Good idea, and thats something that I would make use of too since my game I'm working on doesn't require smoothing or subdivision! Anyways, I guess I'll make this as a draft again until I've sorted all that out (I'm going to focus on other areas for now). Also, would you prefer that I port |
|
I haven't looked too closely at the C++ implementation so I can't say for sure, but if smoothing and subdivision are required for correct usage of this feature, then yes this PR is a good place for them. |
Adding this for an upcoming PR that (I think) requires this.