Closed
Conversation
Contributor
Author
|
Closing in favor of #7 . I won't delete the branch in case we want to go back to this for whatever reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I also took a mini break to work on something else 🙂
I'm not familiar with creating bindings for C, so possibly a lot of this could be wrong. I created this by skimming through this video I found on Youtube and also asking AI what the "Rust equivalent" of something is.
Any help is appreciated!
Motivation
There are 2 main reasons I can think of:
The first is self explanatory.
The second is an idea I had: Rather then having to port the test suite to Rust, we can use the original tests.
This means we don't have to worry about accidentally introducing a bug into the tests making them invalid.
We can eventually rewrite the tests in Rust when we feel like it, but for now this should (hopefully) be good enough!
Also as a mini bonus, it makes it easier to know what still needs to be ported!