Skip to content

Conversation

nicoschmdt
Copy link

No description provided.

Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes to make the PR better.

  • It would be nice to move the python files to a backend folder and the html generation part to a frontend folder. At the moment all files are in the root, mixing back and frontend.
  • The register_service file should exist under a public folder in the frontend folder to automatically be moved to the dist folder.
    • As consequence, robyn only needs a single endpoint to dist

The structure would be something like:

├── backend
│   ├── main.py
│   ├── pyproject.toml
│   └── uv.lock
├── Dockerfile
├── frontend
│   ├── bun.lock
│   ├── index.html
│   ├── package.json
│   ├── public
│   │   └── register_service
│   ├── src
│   │   ├── App.vue
│   │   ├── assets
│   │   │   ├── base.css
│   │   │   └── main.css
│   │   └── main.js
│   └── vite.config.js
└── README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants