Open
Conversation
3 tasks
juhyeonme
reviewed
Oct 18, 2021
Comment on lines
+8
to
+9
| @Getter | ||
| @AllArgsConstructor |
Member
There was a problem hiding this comment.
이 두개는 @Value 하나로 관리할 수 있을것 같습니다
Member
There was a problem hiding this comment.
그리고 Value 사용하게되면 필드에 명시한 private 도 생략가능할것 같습니다.
(default 로 private final 데이터가 유지되므로)
juhyeonme
reviewed
Oct 18, 2021
| @Builder | ||
| @Getter | ||
| @AllArgsConstructor | ||
| public static class Notification { |
Member
There was a problem hiding this comment.
이 Notification 은 PushNotificationMessage 가 포함하고 있는게 맞나요??
포함관계라면 PushNotificationMessage 내부에서 필드 추가해줘야할것 같습니다.
Notification notification;아니라면 Notification 은 다른 클래스로 빼주는게 자연스러울것 같아요
Member
Author
There was a problem hiding this comment.
Notification은 Message의 필드로 사용되는 클래스입니다!
Message 클래스 내부에 포함되도록 변경하면 될까요?
juhyeonme
reviewed
Oct 18, 2021
Comment on lines
+21
to
+23
| private static final String FIREBASE_CONFIG_PATH = "firebase/firebase_service_key.json"; // TODO : add firebase project service key file | ||
| private static final String API_URL = "https://fcm.googleapis.com/v1/projects/{firebase-project-id}/messages:send"; | ||
| private static final String OAUTH_SCOPE = "https://www.googleapis.com/auth/cloud-platform"; |
Member
There was a problem hiding this comment.
급한건 아니지만 이런것들은 yml 설정파일에 넣어주는 편이 좋을것 같습니다
juhyeonme
reviewed
Oct 18, 2021
| PushNotificationMessage.Notification.builder() | ||
| .title(title) | ||
| .body(body) | ||
| .image(null) |
Member
There was a problem hiding this comment.
이 null 은 임시방편인가요?? 아님 항상 null 인건가요?
Member
Author
There was a problem hiding this comment.
임시방편으로 null 값을 넣어놨습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FCM을 이용한 Push Notification Server를 구축하였습니다.