Refactor: The Network Window Wifi List from ListCustomButton to a QListView#108
Closed
gmmcosta15 wants to merge 5 commits intodevfrom
Closed
Refactor: The Network Window Wifi List from ListCustomButton to a QListView#108gmmcosta15 wants to merge 5 commits intodevfrom
ListCustomButton to a QListView#108gmmcosta15 wants to merge 5 commits intodevfrom
Conversation
gmmcosta15
added
the
Refactor
gmmcosta15
changed the title
gmmcosta15
changed the title
ListCustomButton to a QListView
gmmcosta15
force-pushed
the
refactor/network_window
branch
2 times, most recently
from
43c1d5d to
fcd9242
Compare
wifiConnectivityWindow.ui: change horizontalLayout to a vertical layout with a listview and a vertical scrollbar wifiConnectivityWindow.py: generated file from QtDesigner with some optimizations Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
Signed-off-by: Guilherme Costa <guiherme.costa@blockstec.com>
gmmcosta15
force-pushed
the
refactor/network_window
branch
from
8e085b0 to
736d1d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed?
ListCustomButtonto aQListViewusing MVC architectureBuildNetworkListfromQtCore.QThreadto aQtCore.QObjectthat uses aQThreadPoolto runNetworkScanRunnabletasks periodically. with aQTimerto trigger scans. Prevents overlapping scans by tracking whether a scan is already in progress.Screenshots
Future Work
Ui_wifi_stacked_pageCo-Authors
Co‑author: @Robert0Mart