Skip to content

Revert "feat/jira-app"#72

Merged
woywro merged 1 commit into
devfrom
revert-70-feat/jira-app
May 8, 2026
Merged

Revert "feat/jira-app"#72
woywro merged 1 commit into
devfrom
revert-70-feat/jira-app

Conversation

@woywro
Copy link
Copy Markdown
Collaborator

@woywro woywro commented May 8, 2026

Reverts #70

Summary by CodeRabbit

  • New Features

    • Added support for Jira webhook authentication with JIRA_WEBHOOK_SECRET configuration.
  • Bug Fixes

    • Improved error handling for Jira API request failures with clearer error messages.
  • Removed Features

    • Removed Forge bridge integration for Jira comment posting. Jira webhook authentication is now the supported method.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 8, 2026

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 29f20786-7c95-47c3-b93c-3215c9893b33

📥 Commits

Reviewing files that changed from the base of the PR and between 899938b and 0f319df.

📒 Files selected for processing (7)
  • .env.example
  • env.ts
  • src/adapters/issue-tracker/jira.test.ts
  • src/adapters/issue-tracker/jira.ts
  • src/lib/adapters.ts
  • src/lib/step-adapters.ts
  • src/routes/jira/dispatch.post.ts

📝 Walkthrough

Walkthrough

This PR removes Forge bridge integration from the codebase by eliminating Forge environment variables, adapter configuration, test coverage, and the dispatch endpoint. The Jira adapter is simplified to use direct API calls with core configuration, and optional Jira webhook secret support is added.

Changes

Forge Bridge Support Removal

Layer / File(s) Summary
Environment Schema
env.ts
Removed FORGE_SHARED_SECRET and FORGE_COMMENT_URL from server env schema; added JIRA_WEBHOOK_SECRET as optional Jira config.
Configuration Examples
.env.example
Removed Forge bridge configuration section and variable placeholders.
Adapter Implementation Refinement
src/adapters/issue-tracker/jira.ts
Simplified error handling on non-OK responses; refactored attachment URL parsing with local variable; updated regex assignment style in acceptance criteria extraction.
Adapter Initialization
src/lib/adapters.ts, src/lib/step-adapters.ts
Removed forgeCommentUrl and forgeSharedSecret from JiraAdapter constructor configuration in both adapter factory functions.
Tests and Endpoint Removal
src/adapters/issue-tracker/jira.test.ts, src/routes/jira/dispatch.post.ts
Deleted entire "postComment via Forge bridge" test suite (105 lines); removed Forge dispatch endpoint entirely.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 The Forge bridge has crossed its final span,
Direct API calls lead the new plan,
Tests and secrets fade to the past,
Simpler config at long, long last! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@woywro woywro merged commit eac7332 into dev May 8, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant