Remove extra sort when listing out leadership council #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes BlackPythonDevs#652 Because we're already sorting the leadership council when assigning the `council` variable, there's no need to try and sort it again in the later `for` loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗:
Issue: #652
Type of Change
Description 📋
What:
When starting up the server locally, we see this liquid warning
This means that liquid is expecting the statement to end after
leader in council, but it sees that there is| sortfollowing, and it is confused by that.Why
While this is only a warning, fixing this bug helps to resolve a tiny bit of confusion when seeing the warning
How
Because we're already sorting the leadership council when assigning the
councilvariable, there's no need to try and sort it again in the laterforloop. So I just removed the| sortfunction and verified that the order of the leadership council page remains the exact sameChecklist ✅
pre-commit run --allAdditional Notes & Screenshots
Add any additional notes or comments that might be helpful for the reviewers.