Skip to content

Move contents of the conference page to the events page #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TimOsahenru
Copy link
Contributor

  • Conference page removed on all languages

  • Events page updated to have an Upcoming conferences section

@TimOsahenru
Copy link
Contributor Author

@kjaymiller I ran the command pre-commit run --all-files before pushing not sure why I still have tests

Copy link
Contributor

@kjaymiller kjaymiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on getting this.

Biggest comment is you can remove the contents. leaving them in the comments is not necessary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the swahili page is not being dynamically being generated. I would prefer that we include include conferences.html like what was done in the other one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of commenting out you can remove these

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't comment, remove

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@TimOsahenru
Copy link
Contributor Author

@kjaymiller made the necessary changes, but I still can't these linting tests to pass. Also, noticed the event page for Hausa translation returns a 404 page, created an issue for it #415

@kjaymiller kjaymiller merged commit 14a7f5a into BlackPythonDevs:gh-pages Sep 15, 2024
1 of 2 checks passed
@kjaymiller kjaymiller linked an issue Sep 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine Conferences and Events to one page
2 participants