-
Notifications
You must be signed in to change notification settings - Fork 64
Move contents of the conference page to the events page #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move contents of the conference page to the events page #414
Conversation
@kjaymiller I ran the command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on getting this.
Biggest comment is you can remove the contents. leaving them in the comments is not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the swahili page is not being dynamically being generated. I would prefer that we include include conferences.html
like what was done in the other one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of commenting out you can remove these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't comment, remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
@kjaymiller made the necessary changes, but I still can't these linting tests to pass. Also, noticed the event page for Hausa translation returns a 404 page, created an issue for it #415 |
Conference page removed on all languages
Events page updated to have an Upcoming conferences section