Adding resonance module#14
Open
TVTien83 wants to merge 16 commits intoBlackHolePerturbationToolkit:mainfrom
Open
Adding resonance module#14TVTien83 wants to merge 16 commits intoBlackHolePerturbationToolkit:mainfrom
TVTien83 wants to merge 16 commits intoBlackHolePerturbationToolkit:mainfrom
Conversation
deleted the weak-field limit cases, improved error handling while finding resonance
added phi-theta ratio in the limit cases, added function for finding r-mode of triple resonances.
Added checking ValueError to the limit cases
…ction, add finding e or x of double resonance
…ecalculate frequency ratio functions that work even in special limits, introduce a generic function to unify all finding resonance options
Author
|
I am sorry for changing so much after the first commit of the pull request. I've just remembered that I hadn't changed the README and the comments in this update, so I will introduce everything again. Now every option of finding resonance are unified in the generic function
|
…ition of stable, make use of the existing function in resonance.py, and add option of finding triple resonance with given a and x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented some calculation of finding resonance in a new module resonance.py, include:
Finding$z_-^2$ of $r\text{-}\theta$ and $r\text{-}\phi$ resonant orbit in the weak-field(deleted because they are't needed)