Skip to content

feat(statics): adding new coin feature to identify evm coins in UI #6535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
+47 −6
Merged

feat(statics): adding new coin feature to identify evm coins in UI #6535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions modules/statics/src/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,11 @@ export enum CoinFeature {
*/
EVM_COMPATIBLE_IMS = 'evm-compatible-ims',

/**
* This coin is an EVM compatible coin and should use common EVM logic in UI
*/
EVM_COMPATIBLE_UI = 'evm-compatible-ui',

/**
* This coin is an EVM compatible coin which supports unsigned sweep recovery
*/
Expand Down
48 changes: 42 additions & 6 deletions modules/statics/src/coins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,13 @@ export const coins = CoinMap.fromCoins([
18,
UnderlyingAsset.SEIEVM,
BaseUnit.ETH,
[...EVM_FEATURES, CoinFeature.SHARED_EVM_SIGNING, CoinFeature.SHARED_EVM_SDK, CoinFeature.EVM_COMPATIBLE_IMS]
[
...EVM_FEATURES,
CoinFeature.SHARED_EVM_SIGNING,
CoinFeature.SHARED_EVM_SDK,
CoinFeature.EVM_COMPATIBLE_IMS,
CoinFeature.EVM_COMPATIBLE_UI,
Copy link
Contributor

@rv-bitgo rv-bitgo Jul 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Not a blocker for this PR] My Concerns continue to grow with increasing number of coin features with different combinations.
Could we not use any existing flag to verify the compatibility in UI?

]
),
account(
'42cd26d1-706d-40f6-bcce-7cb125e6f617',
Expand All @@ -739,7 +745,13 @@ export const coins = CoinMap.fromCoins([
18,
UnderlyingAsset.SEIEVM,
BaseUnit.ETH,
[...EVM_FEATURES, CoinFeature.SHARED_EVM_SIGNING, CoinFeature.SHARED_EVM_SDK, CoinFeature.EVM_COMPATIBLE_IMS]
[
...EVM_FEATURES,
CoinFeature.SHARED_EVM_SIGNING,
CoinFeature.SHARED_EVM_SDK,
CoinFeature.EVM_COMPATIBLE_IMS,
CoinFeature.EVM_COMPATIBLE_UI,
]
),
account(
'9fbfb875-fb80-4a37-b844-48b9e48dfcdd',
Expand Down Expand Up @@ -1406,7 +1418,13 @@ export const coins = CoinMap.fromCoins([
18,
UnderlyingAsset.KAIA,
BaseUnit.ETH,
[...EVM_FEATURES, CoinFeature.SHARED_EVM_SIGNING, CoinFeature.SHARED_EVM_SDK, CoinFeature.EVM_COMPATIBLE_IMS]
[
...EVM_FEATURES,
CoinFeature.SHARED_EVM_SIGNING,
CoinFeature.SHARED_EVM_SDK,
CoinFeature.EVM_COMPATIBLE_IMS,
CoinFeature.EVM_COMPATIBLE_UI,
]
),
account(
'f6be6f3d-ebac-49fc-8c73-e5b1fc115778',
Expand All @@ -1416,7 +1434,13 @@ export const coins = CoinMap.fromCoins([
18,
UnderlyingAsset.KAIA,
BaseUnit.ETH,
[...EVM_FEATURES, CoinFeature.SHARED_EVM_SIGNING, CoinFeature.SHARED_EVM_SDK, CoinFeature.EVM_COMPATIBLE_IMS]
[
...EVM_FEATURES,
CoinFeature.SHARED_EVM_SIGNING,
CoinFeature.SHARED_EVM_SDK,
CoinFeature.EVM_COMPATIBLE_IMS,
CoinFeature.EVM_COMPATIBLE_UI,
]
),
account(
'bc8541c1-b552-48a6-9a43-1c9b11c43227',
Expand All @@ -1426,7 +1450,13 @@ export const coins = CoinMap.fromCoins([
18,
UnderlyingAsset.IRYS,
BaseUnit.ETH,
[...EVM_FEATURES, CoinFeature.SHARED_EVM_SIGNING, CoinFeature.SHARED_EVM_SDK, CoinFeature.EVM_COMPATIBLE_IMS]
[
...EVM_FEATURES,
CoinFeature.SHARED_EVM_SIGNING,
CoinFeature.SHARED_EVM_SDK,
CoinFeature.EVM_COMPATIBLE_IMS,
CoinFeature.EVM_COMPATIBLE_UI,
]
),
account(
'8861d96c-f1a1-436a-8eb7-950f73f53c3a',
Expand All @@ -1436,7 +1466,13 @@ export const coins = CoinMap.fromCoins([
18,
UnderlyingAsset.IRYS,
BaseUnit.ETH,
[...EVM_FEATURES, CoinFeature.SHARED_EVM_SIGNING, CoinFeature.SHARED_EVM_SDK, CoinFeature.EVM_COMPATIBLE_IMS]
[
...EVM_FEATURES,
CoinFeature.SHARED_EVM_SIGNING,
CoinFeature.SHARED_EVM_SDK,
CoinFeature.EVM_COMPATIBLE_IMS,
CoinFeature.EVM_COMPATIBLE_UI,
]
),
account(
'251b78df-90c5-4ff5-b07a-8cc23f27c5ff',
Expand Down