Skip to content

feat: optional walletLabel key card #6468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

feat: optional walletLabel key card #6468

merged 1 commit into from
Jul 22, 2025

Conversation

bitgoAaron
Copy link
Contributor

  • the new UI will allow users to create keycards before specifying a wallet label, so we need to make this field optional & not render the label if its not specified

Ticket: CE-6422

- the new UI will allow users to create
  keycards before specifying a wallet
  label, so we need to make this field
  optional & not render the label if
  its not specified

Ticket: CE-6422
@bitgoAaron bitgoAaron marked this pull request as ready for review July 16, 2025 17:21
@bitgoAaron bitgoAaron requested review from a team as code owners July 16, 2025 17:21
doc.text(walletLabel, left(0), y);

if (curve || walletLabel) {
const title = curve ? KeyCurveName[curve] + ' key:' : 'wallet named:';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it makes sense to use wallet id instead of curve for the title?

Actually I don't see a walletID in the keycard which I guess is important though, how can somebody identify the wallet with just user key and wallet label is something which can change down the line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we generate the keycard before we create the wallet, and in the new UI we generate the card before we even prompt for a wallet name. Client can name the file anything they want at anytime

@bitgoAaron bitgoAaron merged commit 0624e90 into master Jul 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants