feat: optional walletLabel key card #6468
Merged
+26
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the new UI will allow users to create keycards before specifying a wallet label, so we need to make this field optional & not render the label if its not specified Ticket: CE-6422
sachushaji
approved these changes
Jul 17, 2025
| doc.text(walletLabel, left(0), y); | ||
|
|
||
| if (curve || walletLabel) { | ||
| const title = curve ? KeyCurveName[curve] + ' key:' : 'wallet named:'; |
There was a problem hiding this comment.
Will it makes sense to use wallet id instead of curve for the title?
Actually I don't see a walletID in the keycard which I guess is important though, how can somebody identify the wallet with just user key and wallet label is something which can change down the line
There was a problem hiding this comment.
we generate the keycard before we create the wallet, and in the new UI we generate the card before we even prompt for a wallet name. Client can name the file anything they want at anytime
jamesmili
approved these changes
Jul 22, 2025
Samyakk123
approved these changes
Jul 22, 2025
mohammadalfaiyazbitgo
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CE-6422