feat(abstract-utxo): verify paygo #6445
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
christopher-fong
force-pushed
the
BTC-2118.verify-proof
branch
3 times, most recently
from
26ae7f1 to
26d42d4
Compare
modules/abstract-utxo/src/transaction/fixedScript/explainTransaction.ts
Outdated
Show resolved
Hide resolved
modules/abstract-utxo/src/transaction/fixedScript/explainTransaction.ts
Outdated
Show resolved
Hide resolved
christopher-fong
force-pushed
the
BTC-2118.verify-proof
branch
from
00228cb to
b2986c1
Compare
modules/abstract-utxo/src/transaction/getPayGoVerificationPubkey.ts
Outdated
Show resolved
Hide resolved
christopher-fong
force-pushed
the
BTC-2118.verify-proof
branch
2 times, most recently
from
5b6f7b0 to
c7c914b
Compare
christopher-fong
force-pushed
the
BTC-2118.verify-proof
branch
from
c7c914b to
3dee875
Compare
modules/abstract-utxo/src/transaction/fixedScript/explainTransaction.ts
Outdated
Show resolved
Hide resolved
| */ | ||
| export function getPayGoVerificationPubkey(network: utxolib.Network): string | undefined { | ||
| if (utxolib.isTestnet(network)) { | ||
| return Networks.test.bitcoin.paygoAddressAttestationPubkey; |
There was a problem hiding this comment.
it's a bit of a shame that we have to pull in the whole bloated statics library just for these few bytes
it would be better if we simply hardcoded this value in the AbstractUtxo module itself
There was a problem hiding this comment.
I agree as well, at first I didn't know that abstract-utxo didn't have statics as a dependency, and we are only importing it for the pubkey
There was a problem hiding this comment.
I think we should leave it as is since its part of the statics and its where we store constants
There was a problem hiding this comment.
I think we should leave it as is since its part of the statics and its where we store constants
that's not true, there are plenty of constants that we do not store in statics (eg utxolib.networks)
statics should contain pretty minimal definitions of coins
christopher-fong
force-pushed
the
BTC-2118.verify-proof
branch
2 times, most recently
from
7b4548c to
ee7e179
Compare
modules/abstract-utxo/src/transaction/fixedScript/explainTransaction.ts
Outdated
Show resolved
Hide resolved
christopher-fong
force-pushed
the
BTC-2118.verify-proof
branch
from
b7aa3d1 to
ed9ea13
Compare
christopher-fong
force-pushed
the
BTC-2118.verify-proof
branch
from
ed9ea13 to
5b4279e
Compare
TICKET: BTC-2118