-
Notifications
You must be signed in to change notification settings - Fork 295
feat(abstract-utxo): verify paygo #6445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
26ae7f1
to
26d42d4
Compare
modules/abstract-utxo/src/transaction/fixedScript/explainTransaction.ts
Outdated
Show resolved
Hide resolved
modules/abstract-utxo/src/transaction/fixedScript/explainTransaction.ts
Outdated
Show resolved
Hide resolved
00228cb
to
b2986c1
Compare
modules/abstract-utxo/src/transaction/getPayGoVerificationPubkey.ts
Outdated
Show resolved
Hide resolved
5b6f7b0
to
c7c914b
Compare
c7c914b
to
3dee875
Compare
modules/abstract-utxo/src/transaction/fixedScript/explainTransaction.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please squash commits
*/ | ||
export function getPayGoVerificationPubkey(network: utxolib.Network): string | undefined { | ||
if (utxolib.isTestnet(network)) { | ||
return Networks.test.bitcoin.paygoAddressAttestationPubkey; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a bit of a shame that we have to pull in the whole bloated statics
library just for these few bytes
it would be better if we simply hardcoded this value in the AbstractUtxo
module itself
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree as well, at first I didn't know that abstract-utxo
didn't have statics
as a dependency, and we are only importing it for the pubkey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should leave it as is since its part of the statics and its where we store constants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should leave it as is since its part of the statics and its where we store constants
that's not true, there are plenty of constants that we do not store in statics
(eg utxolib.networks
)
statics
should contain pretty minimal definitions of coins
7b4548c
to
ee7e179
Compare
modules/abstract-utxo/src/transaction/fixedScript/explainTransaction.ts
Outdated
Show resolved
Hide resolved
b7aa3d1
to
ed9ea13
Compare
TICKET: BTC-2118