feat(bsc): added support for mpcv2 in recovery #5957

shashankms288 · 2025-04-14T12:58:36Z

modules/sdk-coin-bsc/src/bsc.ts

modules/sdk-coin-bsc/src/lib/transactionBuilder.ts

rv-bitgo · 2025-05-30T10:28:12Z

modules/abstract-eth/src/abstractEthLikeNewCoins.ts

-      action: 'balance',
-      address: address,
-    });
+  async queryAddressBalance(address: string, apiKey?: string): Promise<any> {


let's update the function documentation with this new param.

Need more context.

parasgarg-bitgo · 2025-05-30T10:53:45Z

modules/abstract-eth/src/abstractEthLikeNewCoins.ts

-      action: 'balance',
-      address: address,
-    });
+  async queryAddressBalance(address: string, apiKey?: string): Promise<any> {


We don't need to update this method signature.
Please refer the implementation of recoveryBlockchainExplorerQuery in Coredoa, Oas, Flr (any other EVM coin) to see how we are fetching APIKey there.

parasgarg-bitgo · 2025-05-30T10:54:03Z

modules/abstract-eth/src/abstractEthLikeNewCoins.ts

@@ -837,15 +841,18 @@ export abstract class AbstractEthLikeNewCoins extends AbstractEthLikeCoin {
   * @param {string} address
   * @returns {Promise<number>}
   */
-  async getAddressNonce(address: string): Promise<number> {
+  async getAddressNonce(address: string, apiKey?: string): Promise<number> {


Same as above,
Please refer the implementation of recoveryBlockchainExplorerQuery in Coredoa, Oas, Flr (any other EVM coin) to see how we are fetching APIKey there.

parasgarg-bitgo · 2025-05-30T11:19:00Z

modules/abstract-eth/src/abstractEthLikeNewCoins.ts

@@ -2198,7 +2205,7 @@ export abstract class AbstractEthLikeNewCoins extends AbstractEthLikeCoin {
    return txAmount;
  }

-  async recoveryBlockchainExplorerQuery(query: Record<string, string>): Promise<any> {
+  async recoveryBlockchainExplorerQuery(query: Record<string, string>, apiKey?: string): Promise<any> {


Changing this function signature in abstract class will break recovery flow for all other coins.

parasgarg-bitgo · 2025-05-30T11:19:51Z

modules/sdk-coin-bsc/src/bsc.ts

+    const common = EthereumCommon.forCustomChain(
+      'mainnet',
+      {
+        name: 'bsc',
+        networkId: networkId,
+        chainId: txChainId,
+      },
+      hardfork
+    );


Please consider overriding getCustomChainCommon method from abstract class instead of replicating the complete txn building logic here

parasgarg-bitgo · 2025-05-30T11:22:03Z

modules/sdk-coin-bsc/src/bsc.ts

+    apiKey?: string
+  ): Promise<Record<string, unknown>> {
+    // Add delay before making API call to avoid rate limiting
+    await this.delayBetweenApiCalls();


This should be in the common implementation of - recoveryBlockchainExplorerQuery(query, explorerUrl as string, apiToken)

mullapudipruthvik · 2025-05-30T12:32:55Z

modules/abstract-eth/src/abstractEthLikeNewCoins.ts

@@ -837,15 +841,18 @@ export abstract class AbstractEthLikeNewCoins extends AbstractEthLikeCoin {
   * @param {string} address
   * @returns {Promise<number>}
   */
-  async getAddressNonce(address: string): Promise<number> {
+  async getAddressNonce(address: string, apiKey?: string): Promise<number> {


mullapudipruthvik · 2025-05-30T12:39:35Z

modules/sdk-coin-bsc/src/bsc.ts

+  protected async buildUnsignedSweepTxnTSS(params: RecoverOptions): Promise<OfflineVaultTxInfo | UnsignedSweepTxMPCv2> {
+    if (!params.replayProtectionOptions) {
+      params.replayProtectionOptions = {
+        chain: this.getChain().includes('t') ? '97' : '56',


get the chainId from config

Copilot

Pull Request Overview

This PR adds support for MPCv2 in recovery operations, specifically targeting Binance Smart Chain and Polygon.

Introduces new tests and mock data for MPCv2 recovery and unsigned sweep transactions.
Updates BSC configurations, transaction builder methods, and recovery workflows to support TSS with MPCv2.
Revises dependency versions and API query token naming for consistency.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
modules/sdk-coin-polygon/test/unit/polygon.ts	Adds a new test for handling invalid user key in Polygon recovery.
modules/sdk-coin-bsc/test/unit/bsc.ts	Introduces tests for MPCv2 recovery and sweep transactions; note an unexpected nesting in test structure.
modules/sdk-coin-bsc/test/fixtures/ecdsa.ts	Provides new mock data functions for MPCv2 recovery and unsigned sweep operations.
modules/sdk-coin-bsc/src/lib/transactionBuilder.ts	Adds an addSignature method to support signature handling in transactions.
modules/sdk-coin-bsc/src/bsc.ts	Extends BSC-specific configurations and transaction-building logic to support MPCv2, including rate limiting and replay protection options.
modules/sdk-coin-bsc/package.json	Updates dependencies including sdk-lib-mpc and ethereumjs/tx to required versions.
modules/bitgo/test/v2/unit/recovery.ts	Adds direct nock setups for BSC recovery tests to simulate external API responses.
modules/abstract-eth/src/lib/utils.ts	Refactors the explorer query token parameter from "apikey" to "apiKey".
modules/abstract-eth/src/abstractEthLikeNewCoins.ts	Passes apiKey in recovery and nonce/query functions; adjusts tx building and ensures proper conversion of transaction hex.

Comments suppressed due to low confidence (1)

modules/abstract-eth/src/abstractEthLikeNewCoins.ts:2027

Ensure that 'addHexPrefix' is imported from the appropriate utility library to avoid potential runtime errors. If it's not imported, add the necessary import statement.

txBuilder.from(addHexPrefix(transaction.serializedTxHex) as string);

Copilot · 2025-05-30T12:46:05Z

modules/sdk-coin-bsc/test/unit/bsc.ts

-      bsc.getBaseFactor().should.equal(1e18);
-      bsc.supportsTss().should.equal(true);
-      bsc.allowsAccountConsolidations().should.equal(true);
+  after(function () {


The test suite nests 'describe' blocks inside the 'after' hook, which may prevent these tests from running. Consider moving these 'describe' blocks outside the 'after' hook to ensure proper test execution.

zahin-mohammad

Looks like more work is needed.

TICKET: WIN-4618

github-actions · 2025-08-02T02:15:13Z

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

shashankms288 requested a review from a team as a code owner April 14, 2025 12:58

shashankms288 force-pushed the WIN-4618 branch from 48129d3 to 942998f Compare April 14, 2025 13:20

mullapudipruthvik reviewed Apr 15, 2025

View reviewed changes

modules/sdk-coin-bsc/src/bsc.ts Show resolved Hide resolved

modules/sdk-coin-bsc/src/lib/transactionBuilder.ts Show resolved Hide resolved

shashankms288 force-pushed the WIN-4618 branch from 942998f to 302fd49 Compare May 2, 2025 09:35

shashankms288 force-pushed the WIN-4618 branch from 302fd49 to 9652802 Compare May 15, 2025 13:22

shashankms288 force-pushed the WIN-4618 branch 5 times, most recently from 9084c45 to 6f22a6d Compare May 29, 2025 09:50

shashankms288 marked this pull request as draft May 29, 2025 10:16

shashankms288 force-pushed the WIN-4618 branch 4 times, most recently from 274c78c to de7be29 Compare May 29, 2025 12:48

shashankms288 marked this pull request as ready for review May 29, 2025 13:36

shashankms288 requested review from a team as code owners May 29, 2025 13:36

shashankms288 requested review from kaustubhbitgo and alextse-bg May 29, 2025 13:36

rv-bitgo previously approved these changes May 30, 2025

View reviewed changes

parasgarg-bitgo requested changes May 30, 2025

View reviewed changes

parasgarg-bitgo reviewed May 30, 2025

View reviewed changes

mullapudipruthvik reviewed May 30, 2025

View reviewed changes

mullapudipruthvik requested a review from Copilot May 30, 2025 12:45

Copilot AI reviewed May 30, 2025

View reviewed changes

zahin-mohammad reviewed Jun 2, 2025

View reviewed changes

zahin-mohammad marked this pull request as draft June 2, 2025 22:41

shashankms288 force-pushed the WIN-4618 branch from de7be29 to f2a0cf1 Compare June 4, 2025 06:55

shashankms288 force-pushed the WIN-4618 branch from f2a0cf1 to 32b5fdd Compare June 17, 2025 08:56

feat(sdk-coin-bsc): added support for mpcv2 in recovery

2183a2b

TICKET: WIN-4618

shashankms288 force-pushed the WIN-4618 branch from 32b5fdd to 2183a2b Compare June 17, 2025 09:03

github-actions bot added the stale label Aug 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(bsc): added support for mpcv2 in recovery #5957

feat(bsc): added support for mpcv2 in recovery #5957

Uh oh!

shashankms288 commented Apr 14, 2025

Uh oh!

Uh oh!

Uh oh!

rv-bitgo May 30, 2025

Uh oh!

parasgarg-bitgo May 30, 2025

Uh oh!

parasgarg-bitgo May 30, 2025

Uh oh!

mullapudipruthvik May 30, 2025

Uh oh!

parasgarg-bitgo May 30, 2025

Uh oh!

parasgarg-bitgo May 30, 2025

Uh oh!

parasgarg-bitgo May 30, 2025

Uh oh!

mullapudipruthvik May 30, 2025

Uh oh!

mullapudipruthvik May 30, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 30, 2025

Uh oh!

zahin-mohammad left a comment

Uh oh!

github-actions bot commented Aug 2, 2025

Uh oh!

Uh oh!

feat(bsc): added support for mpcv2 in recovery #5957

Are you sure you want to change the base?

feat(bsc): added support for mpcv2 in recovery #5957

Uh oh!

Conversation

shashankms288 commented Apr 14, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 30, 2025

Choose a reason for hiding this comment

Uh oh!

zahin-mohammad left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 2, 2025

Uh oh!

Uh oh!