chore: increase servewallet timeout. #3574
Conversation
| await page.goto(`http://${host}:${frontendPort}`); | ||
| const elapsed = Date.now() - start; | ||
| console.log(`Connected to servewallet on ${host}:${servewalletPort} after ${elapsed} ms`); | ||
| ; |
There was a problem hiding this comment.
I actually added it on purpose :) I think keeping track of it can help us make sure that the value we use is "reasonable". WDYT?
There was a problem hiding this comment.
(unless you meant the extra ; that I mistakenly added and removed now :D)
There was a problem hiding this comment.
haha yes I meant only the extra ;
|
|
||
| } | ||
| } | ||
| throw new Error(`Timeout exceeded waiting for servewallet on ${host}:${servewalletPort}`); |
There was a problem hiding this comment.
The timeout in the CI errored on this line, I wonder if we shouldn't put the timeout elapsed message before this line instead of in the while loop?
There was a problem hiding this comment.
I'm not sure what you mean, in the while we look a successful connection, here we return an error. What do you suggest we change here?
There was a problem hiding this comment.
oups I didn't read it properly sorry, I looked at the new message that contains elapsed time, but expected it to be a fail error message.
all good from my side 😇
To avoid spurious failures when the servewallet takes more times to be ready, we increase the timeout but also we log how long a successful connection took, in order to help keep track of it.
bznein
force-pushed
the
servewalletTimeout
branch
from
6915335 to
dc1a215
Compare
To avoid spurious failures when the servewallet takes more times to be ready, we increase the timeout but also we log how long a successful connection took, in order to help keep track of it.
Looking at one execution, we were very close to the timeout limit so it does make sense that we had intermittent failures.
Before asking for reviews, here is a check list of the most common things you might need to consider: