master into staging-bitrefill

.github/workflows/playwright.yml

@@ -0,0 +1,41 @@
+name: Playwright Tests
+
+on:
+  push:
+    branches:
+      - '**'
+  pull_request:
+    branches:
+      - '**'
+  workflow_dispatch:
+
+jobs:
+  run-tests:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v3
+        with:
+          node-version: 20
+
+      - name: Install dependencies
+        run: |
+          cd frontends/web
+          npm install
+
+      - name: Install Playwright browsers
+        run: |
+          cd frontends/web
+          npx playwright install --with-deps
+
+      - name: Run Playwright tests
+        run: make webe2etest
+
+      - name: Upload Playwright artifacts
+        if: failure()
+        uses: actions/upload-artifact@v4
+        with:
+          name: playwright-artifacts
+          path: frontends/web/test-results/*

.gitignore

@@ -50,4 +50,8 @@ tags
 !/frontends/web/src/locales/sl/
 !/frontends/web/src/locales/tr/
 !/frontends/web/src/locales/zh/
-!/frontends/web/src/locales/cs/
+!/frontends/web/src/locales/cs/
+
+# Playwright files
+/frontends/web/playwright-report/
+/frontends/web/test-results/

.golangci.yml

@@ -120,6 +120,7 @@ linters:
     - predeclared
     - tenv
     - recvcheck
+    - godot
   disable-all: false
 
 issues:

CHANGELOG.md

@@ -12,6 +12,14 @@
 - Allow up to 6 unused BTC/LTC accounts (previously 5)
 - Add support for New Zealand Dollar (NZD)
 - Fix empty suggested name for BTC account when only BTC is supported by the BitBox.
+- iOS: add launch screen and smooth transition upon opening the app for the first time.
+- Android: fix screen lock authentication loop bug
+- Android/iOS: fix screen lock bug when no authentication is configured on the device
+- Add expert setting to configure gap limit for bitcoin transaction discovery
+- Fix potential crash in the AOPP workflow
+- Windows: fix send/feetarget dropdown UI rendering bug
+- More efficient account initialization by fetching all account Bitcoin xpubs at once
+- iOS: fix wrong timezone when confirming time on BitBox02 (it would always show the time in UTC)
 
 ## v4.48.4
 - macOS: fix potential USB communication issue with BitBox02 bootloaders <v1.1.2 and firmwares <v9.23.1

Makefile

@@ -55,6 +55,8 @@ webtestwatch:
 	cd ${WEBROOT} && $(MAKE) jstest-watch
 webserve:
 	cd ${WEBROOT} && $(MAKE) serve
+webe2etest:
+	cd ${WEBROOT} && $(MAKE) test-e2e
 qt-linux: # run inside dockerdev
 	$(MAKE) buildweb
 	cd frontends/qt && $(MAKE) linux
@@ -66,8 +68,10 @@ qt-windows:
 	$(MAKE) buildweb
 	cd frontends/qt && $(MAKE) windows
 android:
-	$(MAKE) buildweb
 	cd frontends/android && ${MAKE} apk-debug
+# Create signed .apk and .aab.
+android-assemble-release:
+	cd frontends/android && ${MAKE} assemble-release
 ios:
 	cd frontends/ios && ${MAKE} build
 osx-sec-check:
@@ -98,3 +102,5 @@ locize-fix:
 	locize format ${WEBROOT}/src/locales --format json
 go-vendor:
 	go mod vendor
+update-bitbox02-api-go:
+	./scripts/update-bitbox02-api-go.sh

README.md

@@ -92,23 +92,16 @@ code in `frontends/web/src` are automatically detected and rebuilt.
 
 #### UI testing
 
-The tests are run using [jest](https://jestjs.io)
-and [ts-jest](https://www.npmjs.com/package/ts-jest) preprocessor.
-
-Because the app is based on [preact](https://preactjs.com),
-we use [preact-render-spy](https://www.npmjs.com/package/preact-render-spy) package
-instead of [enzyme](https://airbnb.io/enzyme/) to test app components rendering
-and their state.
+The frontend tests are run using [vitest](https://vitest.dev/) and [@testing-library/react](https://testing-library.com/).
 
 To run all test suites, execute `make webtest`.
-If you plan on spending a lot of time in `frontends/web/src` space
-or just keen on doing TDD, use jest's tests watcher:
 
-    cd frontends/web/
-    make jstest-watch
+#### E2E testing
+
+Playwright is used to perform automatic test on some use cases on the webdev version.
 
-To generate coverage report, execute `make jstest-cover` from `frontends/web` dir
-and open `coverage/lcov-report/index.html` in a browser.
+Tests are located under [`frontends/web/tests`](/frontends/web/tests) and can be run with
+`make webe2etest`
 
 #### Run the HTTP API
 
@@ -145,7 +138,14 @@ use a port_number of your choice, launch the following command and go to `http:/
 QTWEBENGINE_REMOTE_DEBUGGING=<port_number> ./frontends/qt/build/osx/BitBox.app/Contents/MacOS/BitBox
 ```
 
-see also https://doc.qt.io/qt-5/qtwebengine-debugging.html
+Or on Windows using PowerShell
+
+```
+$env:QTWEBENGINE_REMOTE_DEBUGGING=<port_number>
+Start-Process .\BitBox.exe
+```
+
+see also https://doc.qt.io/qt-6/qtwebengine-debugging.html
 
 ### CI
 

backend/accounts.go

@@ -29,6 +29,7 @@ import (
 	"github.com/BitBoxSwiss/bitbox-wallet-app/backend/coins/btc"
 	"github.com/BitBoxSwiss/bitbox-wallet-app/backend/coins/btc/addresses"
 	"github.com/BitBoxSwiss/bitbox-wallet-app/backend/coins/btc/blockchain"
+	btctypes "github.com/BitBoxSwiss/bitbox-wallet-app/backend/coins/btc/types"
 	coinpkg "github.com/BitBoxSwiss/bitbox-wallet-app/backend/coins/coin"
 	"github.com/BitBoxSwiss/bitbox-wallet-app/backend/coins/eth"
 	"github.com/BitBoxSwiss/bitbox-wallet-app/backend/config"
@@ -1016,6 +1017,24 @@ outerLoop:
 	return ks, err
 }
 
+// gapLimits returns the gap limits to use, with arguments having priority over config settings.
+func (backend *Backend) gapLimits() *btctypes.GapLimits {
+	gapLimits := backend.arguments.GapLimits()
+
+	if gapLimits == nil {
+		configReceive := uint16(backend.config.AppConfig().Backend.GapLimitReceive)
+		configChange := uint16(backend.config.AppConfig().Backend.GapLimitChange)
+		if configReceive > 0 && configChange > 0 {
+			gapLimits = &btctypes.GapLimits{
+				Receive: configReceive,
+				Change:  configChange,
+			}
+		}
+	}
+
+	return gapLimits
+}
+
 // The accountsAndKeystoreLock must be held when calling this function.
 func (backend *Backend) createAndAddAccount(coin coinpkg.Coin, persistedConfig *config.Account) {
 	if backend.accounts.lookup(persistedConfig.Code) != nil {
@@ -1044,14 +1063,14 @@ func (backend *Backend) createAndAddAccount(coin coinpkg.Coin, persistedConfig *
 
 	// This function is passed as a callback to the BTC account constructor. It is called when the
 	// keystore needs to determine whether an address belongs to an account on its same keystore.
-	getAddressCallback := func(askingAccount *btc.Account, scriptHashHex blockchain.ScriptHashHex) (*addresses.AccountAddress, bool, error) {
+	getAddressCallback := func(coinCode coinpkg.Code, scriptHashHex blockchain.ScriptHashHex) (*addresses.AccountAddress, error) {
 		accountsByKeystore, err := backend.AccountsByKeystore()
 		if err != nil {
-			return nil, false, err
+			return nil, err
 		}
 		rootFingerprint, err := backend.keystore.RootFingerprint()
 		if err != nil {
-			return nil, false, err
+			return nil, err
 		}
 		for _, account := range accountsByKeystore[hex.EncodeToString(rootFingerprint)] {
 			// This only makes sense for BTC accounts.
@@ -1060,22 +1079,22 @@ func (backend *Backend) createAndAddAccount(coin coinpkg.Coin, persistedConfig *
 				continue
 			}
 			// Only return an address if the coin codes match.
-			if btcAccount.Coin().Code() != askingAccount.Coin().Code() {
+			if btcAccount.Coin().Code() != coinCode {
 				continue
 			}
 			if address := btcAccount.GetAddress(scriptHashHex); address != nil {
-				return address, askingAccount == btcAccount, nil
+				return address, nil
 			}
 		}
-		return nil, false, nil
+		return nil, nil
 	}
 
 	switch specificCoin := coin.(type) {
 	case *btc.Coin:
 		account = backend.makeBtcAccount(
 			accountConfig,
 			specificCoin,
-			backend.arguments.GapLimits(),
+			backend.gapLimits(),
 			getAddressCallback,
 			backend.log,
 		)
@@ -1203,20 +1222,23 @@ func (backend *Backend) persistBTCAccountConfig(
 		accountWatch = &t
 	}
 
-	var signingConfigurations signing.Configurations
-	for _, cfg := range supportedConfigs {
-		extendedPublicKey, err := keystore.ExtendedPublicKey(coin, cfg.keypath)
-		if err != nil {
-			log.WithError(err).Errorf(
-				"Could not derive xpub at keypath %s", cfg.keypath.Encode())
-			return err
-		}
+	keypaths := make([]signing.AbsoluteKeypath, len(supportedConfigs))
+	for i, cfg := range supportedConfigs {
+		keypaths[i] = cfg.keypath
+	}
+	xpubs, err := keystore.BTCXPubs(coin, keypaths)
+	if err != nil {
+		log.WithError(err).Errorf("Could not derive xpubs at keypaths")
+		return err
+	}
 
+	var signingConfigurations signing.Configurations
+	for i, cfg := range supportedConfigs {
 		signingConfiguration := signing.NewBitcoinConfiguration(
 			cfg.scriptType,
 			rootFingerprint,
 			cfg.keypath,
-			extendedPublicKey,
+			xpubs[i],
 		)
 		signingConfigurations = append(signingConfigurations, signingConfiguration)
 	}

backend/accounts/account.go

@@ -93,8 +93,9 @@ type Interface interface {
 	TxProposal(*TxProposalArgs) (coin.Amount, coin.Amount, coin.Amount, error)
 	// GetUnusedReceiveAddresses gets a list of list of receive addresses. The result can be one
 	// list of addresses, or if there are multiple types of addresses (e.g. `bc1...` vs `3...`), a
-	// list of lists.
-	GetUnusedReceiveAddresses() []AddressList
+	// list of lists. Returns `ErrSyncInProgress` if the account is not synced yet. Returns an error
+	// if the account is not initialized yet.
+	GetUnusedReceiveAddresses() ([]AddressList, error)
 	CanVerifyAddresses() (bool, bool, error)
 	VerifyAddress(addressID string) (bool, error)