maintenance: make BBApp able to talk to simulator. #3560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bznein
force-pushed
the
bbapp_simulator
branch
2 times, most recently
from
e20717b to
7e99207
Compare
benma
reviewed
Sep 17, 2025
bznein
force-pushed
the
bbapp_simulator
branch
7 times, most recently
from
832dfe8 to
63a23ae
Compare
|
@benma this is ready for another review. The only part I haven't addresses (but I left a comment) is the "IsRunning" method, which I agree is not ideal, but I can't find a different way. |
bznein
force-pushed
the
bbapp_simulator
branch
from
63a23ae to
4e48f6d
Compare
benma
requested changes
Sep 17, 2025
bznein
force-pushed
the
bbapp_simulator
branch
3 times, most recently
from
b69361b to
8b750b7
Compare
benma
reviewed
Sep 17, 2025
| product == bitbox02common.ProductBitBox02PlusMulti { | ||
| if product != nil && (*product == bitbox02common.ProductBitBox02PlusBTCOnly || | ||
| *product == bitbox02common.ProductBitBox02PlusMulti) { | ||
| productName = BitBox02NovaProductName |
There was a problem hiding this comment.
this also has to happen if the product name is inferred in instead of passed directly
backend/devices/bitbox02/device.go
Outdated
| WithField("productName", productName) | ||
|
|
||
| if product != nil { | ||
| log = log.WithField("product", *product) |
There was a problem hiding this comment.
same, would be nice to log it also if it was inferred vs passed
|
|
||
| // Product implements usb.DeviceInfo. | ||
| func (d deviceInfo) Product() string { | ||
| return bitbox02common.FirmwareDeviceProductStringBitBox02Multi |
benma
approved these changes
Sep 18, 2025
benma
requested changes
Sep 18, 2025
bznein
force-pushed
the
bbapp_simulator
branch
6 times, most recently
from
3e31227 to
569a378
Compare
|
@benma ready again :) |
benma
approved these changes
Sep 21, 2025
|
|
||
| // Serial implements usb.DeviceInfo. | ||
| func (d deviceInfo) Serial() string { | ||
| return fmt.Sprintf("v%s", d.version.String()) |
There was a problem hiding this comment.
Fyi, .String() is technically not needed, as it is called when using %s
There was a problem hiding this comment.
Apparently this causes the tests to fail: https://github.com/BitBoxSwiss/bitbox-wallet-app/actions/runs/17909896855/job/50918793278?pr=3560
bznein
force-pushed
the
bbapp_simulator
branch
from
569a378 to
6865016
Compare
This allows devs to use the app without a real device and without relying on the software keystore.
bznein
force-pushed
the
bbapp_simulator
branch
from
6865016 to
c1d4ce2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, this is only enabled for the servewallet, as it is intended to be used in automated testing that uses it.
Before asking for reviews, here is a check list of the most common things you might need to consider: