frontend: show bitrefill address in a blocking dialog #3552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisconnect
commented
Sep 15, 2025
thisconnect
force-pushed
the
frontend-block-bitrefill-when-singing
branch
2 times, most recently
from
5afc79a to
10d8d4c
Compare
|
|
@Beerosagos ready for review. Added a few more commits:
|
Beerosagos
approved these changes
Sep 19, 2025
| // Ensure expected payment method matches account | ||
| if (coinMapping[account.coinCode] !== paymentMethod) { | ||
| alertUser(t('unknownError', { errorMessage: 'Payment method mismatch' })); | ||
| setPendingPayment(false); |
There was a problem hiding this comment.
I think we need a return too here
| const [agreedTerms, setAgreedTerms] = useState(false); | ||
|
|
||
| const [pendingPayment, setPendingPayment] = useState<boolean>(false); | ||
| const [verifyPaymentRequest, setVerifyPaymentRequest] = useState<TTxProposalResult & { address: string } | false>(); |
So the user can confirm the payment on the device.
thisconnect
force-pushed
the
frontend-block-bitrefill-when-singing
branch
from
e68fd76 to
b092422
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the user can confirm the payment on the device.
Before asking for reviews, here is a check list of the most common things you might need to consider: