fix(ci): resolve eslint peer dep conflict breaking npm install#116
Open
fix(ci): resolve eslint peer dep conflict breaking npm install#116
Conversation
Remove unused eslint-config-standard-with-typescript (requires @typescript-eslint/eslint-plugin ^6.4.0, conflicts with ^8.56.1 from PR #107). Also remove its unused peer deps eslint-plugin-n and eslint-plugin-promise. Update actions/checkout to v4, add actions/setup-node@v4, and bump github/codeql-action from v1 to v3. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eslint-config-standard-with-typescriptwhich requires@typescript-eslint/eslint-plugin@^6.4.0, conflicting with^8.56.1introduced by PR chore(deps): bump minimatch, @typescript-eslint/eslint-plugin, @typescript-eslint/parser and markdownlint-cli in /packages/bitbadgesjs-sdk #107. This peer dependency conflict causesnpm installto fail withERESOLVEin CI.eslint-plugin-nandeslint-plugin-promise(none of these three packages are referenced in.eslintrc.json).actions/checkoutfrom v2 to v4 and addactions/setup-node@v4intest.yml(fixes Node.js 20 deprecation warning).github/codeql-actionfrom v1 to v3 incodeql-analysis.yml.Test plan
npm installsucceeds without ERESOLVE errorsnpm run test)🤖 Generated with Claude Code