Skip to content

Conversation

@tokebe
Copy link
Contributor

@tokebe tokebe commented Dec 18, 2025

ES documents are now parsed into dataclasses which generically handle qualifiers and attributes, so the only field names Retriever must know are top-level.

ES documents are now parsed into dataclasses which generically handle
qualifiers and attributes, so the only field names Retriever must know
are top-level.
@tokebe tokebe added tier1 Concerts Tier 1 enhancement New feature or request labels Dec 18, 2025
@tokebe tokebe requested a review from shuchenliu December 18, 2025 22:07
@sentry
Copy link

sentry bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 85.50725% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...retriever/data_tiers/tier_1/elasticsearch/types.py 91.66% 3 Missing and 1 partial ⚠️
..._tiers/tier_1/elasticsearch/aggregating_querier.py 0.00% 3 Missing ⚠️
...ever/data_tiers/tier_1/elasticsearch/transpiler.py 82.35% 1 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
...etriever/data_tiers/tier_1/elasticsearch/driver.py 48.43% <100.00%> (ø)
..._tiers/tier_1/elasticsearch/aggregating_querier.py 23.21% <0.00%> (ø)
...ever/data_tiers/tier_1/elasticsearch/transpiler.py 77.16% <82.35%> (-1.47%) ⬇️
...retriever/data_tiers/tier_1/elasticsearch/types.py 94.20% <91.66%> (-5.80%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

this will need to be replaced in TRAPI 2.0
Copy link
Contributor

@shuchenliu shuchenliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Centralizing the attribute / qualifier processing by parsing ES hits into Edge/ Node dataclass simplifies the result conversion handling. Looks good to me!

@tokebe tokebe merged commit 6281758 into main Dec 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request tier1 Concerts Tier 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants