fix current sensor#32
Open
RichardASC24 wants to merge 1 commit into
Open
Conversation
Kenou2005
requested changes
Mar 9, 2026
| static const float u90 = 0.5f; | ||
| static const float K = 1.4722f / u90; | ||
|
|
||
| static const float alpha_min = 0.5f; |
There was a problem hiding this comment.
These constants define how wide the band is of the filter, setting them equal will remove the adaptive aspect of your filter, these values must be changed
| {} | ||
|
|
||
|
|
||
| // ================= Initialization ================= |
There was a problem hiding this comment.
Headers should sit on top of what your documenting
| // ================= Initialization ================= | ||
|
|
||
| void CurrentSensor::begin() { | ||
|
|
|
|
||
| // ================= Initialization ================= | ||
|
|
||
| void CurrentSensor::begin() { |
There was a problem hiding this comment.
Rename to setup to keep things consistent in .ino setup function
| #include "CurrentSensor.h" | ||
| #include <math.h> | ||
|
|
||
| // ================= Filter Parameters ================= |
There was a problem hiding this comment.
The variables are meaningless without context, give them some comments regarding what they change
|
|
||
| void CurrentSensor::begin() { | ||
|
|
||
| pinMode(_adcPin, INPUT); |
| private: | ||
|
|
||
| // Hardware | ||
| uint8_t _adcPin; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.