Conversation
Levi-Lesches
reviewed
Dec 2, 2024
Comment on lines
+58
to
+60
| if (command.hasRoverCoordinatesOverrideOverride()) { | ||
| _handleGpsData(command.roverCoordinatesOverrideOverride, true); | ||
| } |
Member
There was a problem hiding this comment.
And stop tracking here, so that the next GPS update doesn't immediately override our override
Comment on lines
+68
to
+71
| if (_currentCommand.hasRoverCoordinatesOverrideOverride() && | ||
| !isRoverOverride) { | ||
| return; | ||
| } |
Member
There was a problem hiding this comment.
This is tricky because having a nullable field is kind of "sticky":
- the field starts off never having been sent:
has()is false - the field is sent once, now
has()is true - _if you use
.merge(),has()will always stay true!
In this case you're not using merge, but it's not impossible to think we'd want to, and then this would start subtly causing bugs. What we can do instead:
- have a
GpsCoordinatesfield on this class for theroverPosition - when tracking, each
_handleGpsDataoverrides that position - when a manual override is sent, override the position and take us out of tracking mode
- now
_handleGpsDatawon't even try to override the position until we start tracking again
Levi-Lesches
reviewed
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.