Allow the other mods to generate stuff in our biomes#48
Open
gpollo wants to merge 1 commit intoBenimatic:masterfrom
Open
Allow the other mods to generate stuff in our biomes#48gpollo wants to merge 1 commit intoBenimatic:masterfrom
gpollo wants to merge 1 commit intoBenimatic:masterfrom
Conversation
Owner
|
Just wanted to say thanks for submitting this. I want to test this out with other mods before I approve it. Other mods generation, like say, oil wells destroying progression features would be undesirable. |
|
Maybe making sure the population event is not fired withing a 2 chunk radius of progression features? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was frustated by the fact that Buildcraft's oil didn't spawn in the Twilight Forest. After some playing around both source code, I found out that Twilight Forest didn't raise a
PopulateChunkEvent.Preevent. Oil now spawn in Twilight Forest and any other mod that use that kind of callback to generate stuff will work. Here's the small changes.