[WIP]Audit-Code4rena-2024-12: Compare the different files With Fix

LICENSE.md

@@ -13,7 +13,7 @@ Licensed Work: BendDAO V2 Protocol. The Licensed Work is (c) 2023 BendDAO
 
 Additional Use Grant: Any uses listed and defined at this [LICENSE](./LICENSE.md)
 
-Change Date: The earlier of 1 Octor 2026 or a date specified at v2-license-date.benddao.eth
+Change Date: The earlier of 1 September 2027 or a date specified at v2-license-date.benddao.eth
 
 Change License: MIT
 

README.md

@@ -1,28 +1,46 @@
+```
+######                       ######     #    #######
+#     # ###### #    # #####  #     #   # #   #     #
+#     # #      ##   # #    # #     #  #   #  #     #
+######  #####  # #  # #    # #     # #     # #     #
+#     # #      #  # # #    # #     # ####### #     #
+#     # #      #   ## #    # #     # #     # #     #
+######  ###### #    # #####  ######  #     # #######
+```
+
 # BendDAO Protocol V2
 
+This repository contains the smart contracts source code and markets configuration for BendDAO V2 Protocol. The repository uses Foundry as development environment for compilation, testing and deployment tasks.
+
 ---
 
 ## What are BendDAO Protocol V2?
 
-TBD
+BendDAO V2 Protocol brings you composable lending and leverage. It allows anyone to borrow in an overcollateralized fashion, leverage savings on MakerDAO, leverage stake on Lido, leverage restake with EigenLayer derivatives, bringing together lending and leverage in the same protocol!
 
----
+V2 Protocol has three user sides to it:
+
+Lenders deposit assets to earn passive yield.
 
-## Contracts overview
+Borrowers can use ERC20 & ERC721 as collaterals to borrow assets in an overcollateralized fashion.
 
-TBD
+Leverage users can use ERC721 as collaterals to borrow assets to create leverage positions, which can be used across DeFi, NFTs, RWA, etc.
 
 ---
 
 ## Documentation
 
-TBD
+[Doc Hub](https://docs.benddao.xyz)
+
+[User Guide](https://docs.benddao.xyz/portal/v/v2)
+
+[Dev Guide](https://docs.benddao.xyz/developers/v/v2-1)
 
 ---
 
 ## Audits
 
-TBD
+All audits are stored in the [audits](./audits/) folder and [online](https://docs.benddao.xyz/portal/v/v2/security-and-risks/audits).
 
 ---
 
@@ -32,34 +50,6 @@ A bug bounty is open on Immunefi. The rewards and scope are defined [here](https
 
 ---
 
-## Deployment Addresses
-
-TBD
-
----
-
-## Importing package
-
-Using npm:
-
-```bash
-npm install @benddao/bend-v2
-```
-
-Using forge:
-
-```bash
-forge install @benddao/[email protected]
-```
-
-Using git submodules:
-
-```bash
-git submodule add @benddao/[email protected] lib/bend-v2
-```
-
----
-
 ## Testing with [Foundry](https://github.com/foundry-rs/foundry) 🔨
 
 For testing, make sure `yarn` and `foundry` are installed.
@@ -74,26 +64,14 @@ npm run test
 
 ---
 
-## Testing with Hardhat
-
-Only a few tests are run with Hardhat.
-
-Just run:
-
-```bash
-yarn test:hardhat
-```
-
----
-
 ## Test coverage
 
 Test coverage is reported using [foundry](https://github.com/foundry-rs/foundry) coverage with [lcov](https://github.com/linux-test-project/lcov) report formatting (and optionally, [genhtml](https://manpages.ubuntu.com/manpages/xenial/man1/genhtml.1.html) transformer).
 
 To generate the `lcov` report, run the following:
 
 ```bash
-npm run coverage:forge
+npm run coverage:lcov
 ```
 
 The report is then usable either:
@@ -118,27 +96,7 @@ In the case the storage layout snapshots checked by `storage-layout.sh` are not
 
 ## Deployment & Upgrades
 
-### Network mode (default)
-
-Run the Foundry deployment script with:
-
-```bash
-npm run deploy:goerli
-```
-
-### Local mode
-
-First start a local EVM:
-
-```bash
-npm run anvil:goerli
-```
-
-Then run the Foundry deployment script in a separate shell:
-
-```bash
-npm run deploy:local
-```
+Documents in the [script](./script/) folder.
 
 ---
 
@@ -150,4 +108,6 @@ For any questions or feedback, you can send an email to [[email protected]](
 
 ## Licensing
 
-The code is under the Business Source License 1.1, see [`LICENSE`](./LICENSE).
+The primary license for BendDAO v2 is the Business Source License 1.1 (`BUSL-1.1`), see [`LICENSE`](./LICENSE).
+
+However, some files can also be licensed under `GPL-2.0-or-later` (as indicated in their SPDX headers).

audits/2024-09-03-BendDAO-V2-Code4rena-Report.md

@@ -0,0 +1 @@
+[Report URL](https://code4rena.com/reports/2024-07-benddao)

config/eth-mainnet.json

@@ -1,13 +1,13 @@
 {
   "chainId": 1,
   "rpcAlias": "mainnet",
-  "forkBlockNumber": 19369370,
-  "treasury": "0x472FcC65Fab565f75B1e0E861864A86FE5bcEd7B",
+  "forkBlockNumber": 20659780,
+  "treasury": "0xA14a73522D2f60D1ff96D52C5A8D1177940227a8",
   "wrappedNative": "0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2",
-  "ProxyAdmin": "0x0000000000000000000000000000000000000000",
-  "AddressProvider": "0x0000000000000000000000000000000000000000",
-  "ACLAdmin": "0xe6b80f77a8B8FcD124aB748C720B7EAEA83dDb4C",
-  "ACLManager": "0x0000000000000000000000000000000000000000",
-  "PriceOracle": "0x0000000000000000000000000000000000000000",
-  "PoolManager": "0x0000000000000000000000000000000000000000"
+  "ProxyAdmin": "0x3b241a4338f0C3f67aFE0e130ccB653D0Ef3767C",
+  "AddressProvider": "0xa9Afc955d549D43DB056655b98FaB02870A45Fcd",
+  "ACLAdmin": "0x868964fa49a6fd6e116FE82c8f4165904406f479",
+  "ACLManager": "0xfc76aCB1C685fC427894652616feB4E303e4611a",
+  "PriceOracle": "0x3F8133A472C1d94Be4A562C44c337409c04Ae244",
+  "PoolManager": "0x0b870d974fB968B2E06798ABBD2563c80933D148"
 }

release/abis/BVault.json

@@ -197,7 +197,7 @@
   },
   {
     "type": "function",
-    "name": "setApprovalForAll",
+    "name": "setAuthorization",
     "inputs": [
       {
         "name": "poolId",
@@ -521,7 +521,7 @@
   },
   {
     "type": "event",
-    "name": "SetApprovalForAll",
+    "name": "SetAuthorization",
     "inputs": [
       {
         "name": "sender",