Add search to settings#1244
Conversation
|
Hi, the How To Build doc can be found here: https://github.com/BeamMW/beam-ui/wiki/How-to-build-Beam-desktop-UI If you run into issues with the setup, you can join https://t.me/beamdevsupport and we'll assist you. Please make sure that everything works as expected. |
0f69e56 to
41e5e2a
Compare
41e5e2a to
6e66f80
Compare
|
Thanks, I followed the build doc and verified this locally. Checks run:
Build passed and produced build/Beam Wallet.app. I also added the generated i18n entries for the two new search strings and force-pushed commit 6e66f80. |
|
Good that it builds, but none of these checks say that you actually tested the feature, please record a short video testing the feature. |
|
Recorded a short feature test video here: beam-settings-search.mp4\n\nTested locally on macOS with a throwaway empty wallet. The video shows:\n- Settings search opened from the Settings page\n- |
|
Please take a look at the issue again w.r.t. the position and behavior of the search icon and the search bar as well as the no results found case. If you use AI to write the code, at least answer me yourself.\n |
Closes #824
Summary
Search by section name or parameter.No results foundempty state.Validation
git diff --checkqmllint ui/view/Settings.qml ui/view/controls/SettingsFoldable.qml(only existing Beam.Wallet import/generated-type warnings when run outside the built app context)cmake --build build-verify --target beam-wallet-ui --parallel 4show,privacy,bitcoin, and a no-match query.Test video