Skip to content

Add search to settings#1244

Closed
Dyltom wants to merge 2 commits into
BeamMW:masterfrom
Dyltom:codex/settings-search
Closed

Add search to settings#1244
Dyltom wants to merge 2 commits into
BeamMW:masterfrom
Dyltom:codex/settings-search

Conversation

@Dyltom
Copy link
Copy Markdown

@Dyltom Dyltom commented May 11, 2026

Closes #824

Summary

  • Moves the Settings search control into the Settings header so the icon sits at the top right and expands in place.
  • Uses the requested placeholder text: Search by section name or parameter.
  • Filters by section title, parameter labels, selected dropdown values, text/numeric values, and connection fields while excluding command-button/link labels.
  • Expands and highlights matching sections, and shows the centered No results found empty state.

Validation

  • git diff --check
  • qmllint ui/view/Settings.qml ui/view/controls/SettingsFoldable.qml (only existing Beam.Wallet import/generated-type warnings when run outside the built app context)
  • cmake --build build-verify --target beam-wallet-ui --parallel 4
  • Manual macOS test with a throwaway empty wallet for show, privacy, bitcoin, and a no-match query.

Test video

@Maxnflaxl
Copy link
Copy Markdown
Member

Hi, the How To Build doc can be found here: https://github.com/BeamMW/beam-ui/wiki/How-to-build-Beam-desktop-UI

If you run into issues with the setup, you can join https://t.me/beamdevsupport and we'll assist you.

Please make sure that everything works as expected.

@Dyltom Dyltom force-pushed the codex/settings-search branch from 0f69e56 to 41e5e2a Compare May 12, 2026 03:38
@Dyltom Dyltom force-pushed the codex/settings-search branch from 41e5e2a to 6e66f80 Compare May 12, 2026 04:04
@Dyltom
Copy link
Copy Markdown
Author

Dyltom commented May 12, 2026

Thanks, I followed the build doc and verified this locally.

Checks run:

  • git diff --check origin/master...HEAD
  • qmllint ui/view/Settings.qml ui/view/controls/SettingsFoldable.qml (only existing/generated-type import warnings when run outside the built app context)
  • CMake configure with Qt 6.11, OpenSSL 3, and local Boost 1.75 per the wiki
  • cmake --build build-boost175 --target beam-wallet-ui --parallel 4

Build passed and produced build/Beam Wallet.app. I also added the generated i18n entries for the two new search strings and force-pushed commit 6e66f80.

@Maxnflaxl
Copy link
Copy Markdown
Member

Good that it builds, but none of these checks say that you actually tested the feature, please record a short video testing the feature.

@Dyltom
Copy link
Copy Markdown
Author

Dyltom commented May 12, 2026

Recorded a short feature test video here: beam-settings-search.mp4\n\nTested locally on macOS with a throwaway empty wallet. The video shows:\n- Settings search opened from the Settings page\n- privacy filtering to and expanding the Privacy section\n- bitcoin filtering to and expanding the Bitcoin settings\n- a no-match query showing "No settings found"\n- clearing search restoring the full settings list

@Maxnflaxl
Copy link
Copy Markdown
Member

Please take a look at the issue again w.r.t. the position and behavior of the search icon and the search bar as well as the no results found case.
The video does not match the position and behavior outlined in the issue.

If you use AI to write the code, at least answer me yourself.\n

@Dyltom Dyltom closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add search to Settings

2 participants