evaluate_performance should actually use the parameter num_samples#166
Merged
evaluate_performance should actually use the parameter num_samples#166
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a hardcoded sample size in evaluate_performance by using the num_samples parameter.
- Updated the
Predictivecall to pass throughnum_samplesinstead of always using1000. - Preserved the
parallel=Truebehavior unchanged.
Comments suppressed due to low confidence (2)
collab/foraging/toolkit/evaluate.py:11
- Update the function docstring to reflect that
num_samplesis now actually used when instantiatingPredictive, and adjust the default description if needed.
predictive = Predictive(
collab/foraging/toolkit/evaluate.py:12
- Add or update a unit test to verify that passing a custom
num_samplesvalue actually changes the number of samples used byPredictive.
model=model, guide=guide, num_samples=num_samples, parallel=True
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.