fix(ci): extend bats TAP count mismatch fix to macOS - #2401
Merged
Conversation
f3aaf30 fixed --tap + --jobs causing bats to declare a test plan it can't fulfil on Linux by forcing TEST_JOBS=1. The macOS job was left on TEST_JOBS=detect with GNU parallel explicitly installed, hitting the same mismatch and exiting with code 1 despite all tests passing. Remove the parallel install step and apply TEST_JOBS=1 unconditionally.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--tap+--jobscauses bats to declare a test plan it can't fulfil on Linux, fixed by forcingTEST_JOBS=1. The macOS job was left onTEST_JOBS=detectwith GNU parallel explicitly installed, hitting the same mismatch and exiting with code 1 despite all tests passing.Removes the parallel install step and applies
TEST_JOBS=1unconditionally, matching the existing Linux fix.This is a split-out of #2395, isolating the CI fix from the unrelated 1Password/Herdr completion additions and local test-runner changes bundled in that PR. Commit is cherry-picked with original authorship preserved (author: @leventyalcin).
Types of changes