Skip to content

Feature/improved search and results #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

androidseb
Copy link

This PR proposes some changes to improve the search functionality by:

  • allowing the search to be more specific by passing in a location latlng box
  • making Location search results richer by returning the title and description fields

Pre-launch Checklist

  • I made sure the project builds.
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is does not need version changes.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I rebased onto main.
  • I added new tests to check the change I am making, or this PR does not need tests.
  • I made sure all existing and new tests are passing.
  • I ran dart format . and committed any changes.
  • I ran flutter analyze and fixed any errors.

How to use this

Until this PR is merged and integrated into the library's code, you can use the fork by updating your pubspec.yaml file like so:

  #geocoding: ^4.0.0
  geocoding:
    git:
      url: https://github.com/androidseb/flutter-geocoding
      ref: geocoding_sebs_fork_v4.0.0
      path: geocoding

Important note: waiting for confirmation of interest

I would like a confirmation from maintainers that they have interest in adding this functionality first (something as simple as a short reply saying "yes this would be a great addition"). Once I get that confirmation, I'll put further efforts into finalizing this PR.

androidseb added 11 commits June 7, 2025 11:15
geocoding/android/src/main/java/com/baseflow/geocoding/Geocoding.java
geocoding/android/src/main/java/com/baseflow/geocoding/MethodCallHandlerImpl.java
geocoding_platform_interface/lib/src/geocoding_platform_interface.dart
geocoding_platform_interface/lib/src/implementations/method_channel_geocoding.dart
geocoding_platform_interface/test/src/implementations/method_channel_geocoding_test.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant