Skip to content

mainly lint fixing and make it compatible with latest pylint.testutil module #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mainly lint fixing and make it compatible with latest pylint.testutil module #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
description="A Pylint plugin to lint Apache Airflow code.",
long_description=long_description,
long_description_content_type="text/x-rst",
version="0.1.0-alpha.1",
version="0.1.1-alpha.1",
packages=find_packages(where="src"),
package_dir={"": "src"},
install_requires=requirements,
Expand All @@ -28,5 +28,6 @@
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
],
)
2 changes: 1 addition & 1 deletion src/pylint_airflow/checkers/operator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def invalidname(): print("dosomething")
# TODO support other values than constants
task_id = keyword.value.value
continue
elif keyword.arg == "python_callable":
if keyword.arg == "python_callable":
python_callable_name = keyword.value.name

if var_name != task_id:
Expand Down
2 changes: 1 addition & 1 deletion src/pylint_airflow/checkers/xcom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def visit_module(self, node: astroid.Module):
if keyword.arg == "python_callable":
python_callable = keyword.value.name
continue
elif keyword.arg == "task_id":
if keyword.arg == "task_id":
task_id = keyword.value.value

if python_callable:
Expand Down
2 changes: 1 addition & 1 deletion tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import os

import pytest
from pylint.test.test_functional import (
from pylint.testutils import (
LintModuleTest,
FunctionalTestFile,
multiset_difference,
Expand Down